Bugzilla – Attachment 160554 Details for
Bug 35293
Regression: Bug 33390 (QA follow-up) patch overwrote the template changes to bug 25560
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35293: Re-implement bug 30407 functionality
Bug-35293-Re-implement-bug-30407-functionality.patch (text/plain), 2.24 KB, created by
Nick Clemens (kidclamp)
on 2024-01-04 19:25:33 UTC
(
hide
)
Description:
Bug 35293: Re-implement bug 30407 functionality
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2024-01-04 19:25:33 UTC
Size:
2.24 KB
patch
obsolete
>From 30816a59db8e25ef92c4dd6f75bb5009c8e10a60 Mon Sep 17 00:00:00 2001 >From: Alex Buckley <alexbuckley@catalyst.net.nz> >Date: Sun, 12 Nov 2023 21:26:42 +0000 >Subject: [PATCH] Bug 35293: Re-implement bug 30407 functionality >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >To test: >1. Set a book items notforloan status as -1 and set the AllowNotForLoanOverride system preference to 'Allow' >2. Add the following lines to UpdateNotForLoanStatusOnCheckin (the >formatting and indentation is important to keep): > >BK: > -1: ONLYMESSAGE > >3. Check a book item out for patron. >4. Check book item in. >=> Description of notforloan status should be displayed under 'Check in message'. >=> Confirm notforloan status HAS changed. > >5. Apply patch and update database if needed >6. Set book items notforloan status as -1 (or create new one) >7. Check book item out for patron. >8. Check book item in. >=> Description of notforloan status should be displayed under 'Check in >message'. >=> Confirm notforloan status HAS NOT changed. > >Also prove t/db_dependent/Circulation/issue.t > >Sponsored-by: Catalyst IT, New Zealand >Signed-off-by: Anneli Ãsterman <anneli.osterman@koha-suomi.fi> >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > C4/Circulation.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 562cad72671..1c15034cb95 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -2228,7 +2228,7 @@ sub AddReturn { > foreach my $notloan_rule_key (keys %{ $rules->{$item->itype}} ) { > if ( $item->notforloan eq $notloan_rule_key ) { > $messages->{'NotForLoanStatusUpdated'} = { from => $item->notforloan, to => $rules->{$item->itype}->{$notloan_rule_key} }; >- $item->notforloan($rules->{$item->itype}->{$notloan_rule_key})->store({ log_action => 0, skip_record_index => 1, skip_holds_queue => 1 }); >+ $item->notforloan($rules->{$item->itype}->{$notloan_rule_key})->store({ log_action => 0, skip_record_index => 1, skip_holds_queue => 1 }) unless $rules->{$item->itype}->{$notloan_rule_key} eq 'ONLYMESSAGE'; > last; > } > } >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35293
:
158850
|
158851
|
160360
|
160361
|
160362
|
160553
| 160554 |
160555
|
160556