Bugzilla – Attachment 160555 Details for
Bug 35293
Regression: Bug 33390 (QA follow-up) patch overwrote the template changes to bug 25560
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35293: (follow-up) Handle all rules as well
Bug-35293-follow-up-Handle-all-rules-as-well.patch (text/plain), 2.25 KB, created by
Nick Clemens (kidclamp)
on 2024-01-04 19:25:35 UTC
(
hide
)
Description:
Bug 35293: (follow-up) Handle all rules as well
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2024-01-04 19:25:35 UTC
Size:
2.25 KB
patch
obsolete
>From b83181109838a27dbfd12e993c71688458436b17 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Thu, 4 Jan 2024 19:03:11 +0000 >Subject: [PATCH] Bug 35293: (follow-up) Handle all rules as well > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > C4/Circulation.pm | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 1c15034cb95..ca1f3a8d8ac 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -2228,7 +2228,9 @@ sub AddReturn { > foreach my $notloan_rule_key (keys %{ $rules->{$item->itype}} ) { > if ( $item->notforloan eq $notloan_rule_key ) { > $messages->{'NotForLoanStatusUpdated'} = { from => $item->notforloan, to => $rules->{$item->itype}->{$notloan_rule_key} }; >- $item->notforloan($rules->{$item->itype}->{$notloan_rule_key})->store({ log_action => 0, skip_record_index => 1, skip_holds_queue => 1 }) unless $rules->{$item->itype}->{$notloan_rule_key} eq 'ONLYMESSAGE'; >+ $item->notforloan( $rules->{ $item->itype }->{$notloan_rule_key} ) >+ ->store( { log_action => 0, skip_record_index => 1, skip_holds_queue => 1 } ) >+ unless $rules->{ $item->itype }->{$notloan_rule_key} eq 'ONLYMESSAGE'; > last; > } > } >@@ -2236,7 +2238,9 @@ sub AddReturn { > foreach my $notloan_rule_key (keys %{ $rules->{'_ALL_'}} ) { > if ( $item->notforloan eq $notloan_rule_key ) { > $messages->{'NotForLoanStatusUpdated'} = { from => $item->notforloan, to => $rules->{'_ALL_'}->{$notloan_rule_key} }; >- $item->notforloan($rules->{'_ALL_'}->{$notloan_rule_key})->store({ log_action => 0, skip_record_index => 1, skip_holds_queue => 1 }); >+ $item->notforloan( $rules->{'_ALL_'}->{$notloan_rule_key} ) >+ ->store( { log_action => 0, skip_record_index => 1, skip_holds_queue => 1 } ) >+ unless $rules->{ '_ALL_' }->{$notloan_rule_key} eq 'ONLYMESSAGE'; > last; > } > } >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35293
:
158850
|
158851
|
160360
|
160361
|
160362
|
160553
|
160554
| 160555 |
160556