Attachment 160580 Details for Bug 35717 – Bug 35717: Replace GetSuggestionFromBiblionumber

[patch] Bug 35717: Replace GetSuggestionFromBiblionumber

Bug-35717-Replace-GetSuggestionFromBiblionumber.patch (text/plain), 1.68 KB, created by Nick Clemens (kidclamp) on 2024-01-05 18:57:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2024-01-05 18:57:09 UTC

Size: 1.68 KB

patch

obsolete

>From bb2bf58bd83f3138578882bdc8f792420f7ce047 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 10 May 2023 15:21:05 +0200
>Subject: [PATCH] Bug 35717: Replace GetSuggestionFromBiblionumber
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> C4/Acquisition.pm | 16 +++++++++-------
> 1 file changed, 9 insertions(+), 7 deletions(-)
>
>diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm
>index 370030895ef..08f606da4a7 100644
>--- a/C4/Acquisition.pm
>+++ b/C4/Acquisition.pm
>@@ -22,7 +22,7 @@ use Modern::Perl;
> use Carp qw( carp croak );
> use Text::CSV_XS;
> use C4::Context;
>-use C4::Suggestions qw( GetSuggestion GetSuggestionFromBiblionumber ModSuggestion );
>+use C4::Suggestions qw( GetSuggestion ModSuggestion );
> use C4::Biblio qw( GetMarcFromKohaField GetMarcStructure IsMarcStructureInternal );
> use C4::Contract qw( GetContract );
> use C4::Log qw( logaction );
>@@ -1387,12 +1387,14 @@ sub ModReceiveOrder {
>     $order->{invoice_unitprice} ||= $order->{unitprice};
>     $order->{invoice_currency}  ||= Koha::Acquisition::Currencies->get_active->currency;
> 
>-    my $suggestionid = GetSuggestionFromBiblionumber( $biblionumber );
>-    if ($suggestionid) {
>-        ModSuggestion( {suggestionid=>$suggestionid,
>-                        STATUS=>'AVAILABLE',
>-                        biblionumber=> $biblionumber}
>-                        );
>+    if ( $order->{suggestionid} ) {
>+        ModSuggestion(
>+            {
>+                suggestionid => $order->{suggestionid},
>+                STATUS       => 'AVAILABLE',
>+                biblionumber => $biblionumber
>+            }
>+        );
>     }
> 
>     my $result_set = $dbh->selectrow_arrayref(
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 35717: 160576 | 160577 | 160578 | 160579 | 160580 | 160581 | 160582 | 160583 | 164834 | 164835 | 164836 | 164837 | 164838 | 164839 | 164840 | 172871 | 172872 | 172873 | 172874 | 172875 | 172876 | 172877 | 172878 | 172899 | 172900 | 172901