Attachment 160589 Details for Bug 35634 – Bug 35634: (bug 33105 follow-up) fix typo issues_manage vs issue_manage

[patch] Bug 35634: (bug 33105 follow-up) fix typo issues_manage vs issue_manage

Bug-35634-bug-33105-follow-up-fix-typo-issuesmanag.patch (text/plain), 2.38 KB, created by Nick Clemens (kidclamp) on 2024-01-05 19:40:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2024-01-05 19:40:40 UTC

Size: 2.38 KB

patch

obsolete

>From c8b4af9dbedad574240b2a534d52c9d86d474cde Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 3 Jan 2024 14:52:25 +0100
>Subject: [PATCH] Bug 35634: (bug 33105 follow-up) fix typo issues_manage vs
> issue_manage
>
>issue_manage inserted into the DB but issues_manage is tested in the
>controller script.
>
>Test plan:
> git grep issues_manage
>should no longer return any results
>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> acqui/vendor_issues.pl | 2 +-
> api/v1/swagger/paths/acquisitions_vendor_issues.yaml | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/acqui/vendor_issues.pl b/acqui/vendor_issues.pl
>index 4b154e8d99d..bee05028a7e 100755
>--- a/acqui/vendor_issues.pl
>+++ b/acqui/vendor_issues.pl
>@@ -37,7 +37,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
> template_name => "acqui/vendor_issues.tt",
> query => $input,
> type => "intranet",
>- flagsrequired => { acquisition => 'issues_manage' },
>+ flagsrequired => { acquisition => 'issue_manage' },
> }
> );
> 
>diff --git a/api/v1/swagger/paths/acquisitions_vendor_issues.yaml b/api/v1/swagger/paths/acquisitions_vendor_issues.yaml
>index c60b79dac0d..d55cb2a8843 100644
>--- a/api/v1/swagger/paths/acquisitions_vendor_issues.yaml
>+++ b/api/v1/swagger/paths/acquisitions_vendor_issues.yaml
>@@ -88,4 +88,4 @@
> $ref: "../swagger.yaml#/definitions/error"
> x-koha-authorization:
> permissions:
>- acquisition: issues_manage
>+ acquisition: issue_manage
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
>index 4caf7022c46..10b90813f42 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
>@@ -463,7 +463,7 @@
> 
> ([% name | html %])
> [%- CASE 'issue_manage' -%]
>- 
>+ 
> Manage vendor issues
> 
> ([% name | html %])
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 35634: 160460 | 160476 | 160589