Bugzilla – Attachment 160594 Details for
Bug 35695
Remove useless item group code from cataloging_additem.js
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35695: Remove useless JS from cataloging_additem.js
Bug-35695-Remove-useless-JS-from-catalogingadditem.patch (text/plain), 1.38 KB, created by
David Nind
on 2024-01-05 21:03:51 UTC
(
hide
)
Description:
Bug 35695: Remove useless JS from cataloging_additem.js
Filename:
MIME Type:
Creator:
David Nind
Created:
2024-01-05 21:03:51 UTC
Size:
1.38 KB
patch
obsolete
>From 13a6c4b426a0aea506a55150006e627a52597f78 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Wed, 3 Jan 2024 22:57:32 +0000 >Subject: [PATCH] Bug 35695: Remove useless JS from cataloging_additem.js > >To test: >1. APPLY PATCH >2. Turn on EnableItemGroups >3. Go to a record with item groups, or create some. >4. Add an item, making sure items can be added to a group. ( Bug 33639 must be applied ) > >If I am wrong and this code should stay, tell me. I'll fix the jQuery instead of removing it. :) > >Signed-off-by: David Nind <david@davidnind.com> >--- > koha-tmpl/intranet-tmpl/prog/js/cataloging_additem.js | 7 ------- > 1 file changed, 7 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/cataloging_additem.js b/koha-tmpl/intranet-tmpl/prog/js/cataloging_additem.js >index 65a86a2175..b44118e061 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/cataloging_additem.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/cataloging_additem.js >@@ -134,13 +134,6 @@ $(document).ready(function(){ > }); > } > >- $('#item-group-add-or-create-form-select').on('change', function() { >- if ( ! $('input.items-enumchron').val() ) { >- let item_group_selector = '#item-group-' + $(this).val(); >- let enumchron = $(item_group_selector).val(); >- $('input.items-enumchron').val( enumchron ); >- } >- }); > }); > > function CheckTemplateForm(f) { >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35695
:
160508
|
160594
|
161430