Attachment 160708 Details for Bug 35701 – Bug 35701: Do not use t

[patch] Bug 35701: Do not use t

Bug-35701-Do-not-use-t.patch (text/plain), 2.65 KB, created by Owen Leonard on 2024-01-09 16:16:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2024-01-09 16:16:56 UTC

Size: 2.65 KB

patch

obsolete

>From b0a2e57305b9842456415965d9428249a37a277a Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 4 Jan 2024 16:24:26 +0100
>Subject: [PATCH] Bug 35701: Do not use t
>
>To not interfer with the t from I18N
>
>On bug 35329 we are using the I18N TT plugin that is providing the 't'
>subroutine.
>
>This loop is redefining the subroutine, therefore it is not longer
>accessible.
>
>Test plan:
>Edit a patron and confirm the the "Title" dropdown still contain the
>different values of syspref BorrowersTitles.
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> .../prog/en/modules/members/memberentrygen.tt             | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>index 816b7f088f..645040707b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>@@ -283,11 +283,11 @@ legend:hover {
>                                                             Salutation: </label>
>                                                             <select id="btitle" name="title">
>                                                                 <option value=""></option>
>-                                                                [% FOREACH t IN Koha.Preference('BorrowersTitles').split('\|') %]
>-                                                                    [% IF btitle == t %]
>-                                                                        <option value="[% t | html %]" selected="selected">[% t | html %]</option>
>+                                                                [% FOREACH patron_title IN Koha.Preference('BorrowersTitles').split('\|') %]
>+                                                                    [% IF btitle == patron_title %]
>+                                                                        <option value="[% patron_title | html %]" selected="selected">[% patron_title | html %]</option>
>                                                                     [% ELSE %]
>-                                                                        <option value="[% t | html %]">[% t | html %]</option>
>+                                                                        <option value="[% patron_title | html %]">[% t | html %]</option>
>                                                                     [% END %]
>                                                                 [% END %]
>                                                             </select>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 35701: 160535 | 160693 | 160708 | 160709 | 161094 | 161095