Bugzilla – Attachment 160781 Details for
Bug 35757
Sushi service and counter registry tests are failing
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35757: (QA follow-up) Tidy
Bug-35757-QA-follow-up-Tidy.patch (text/plain), 2.36 KB, created by
Nick Clemens (kidclamp)
on 2024-01-10 18:10:07 UTC
(
hide
)
Description:
Bug 35757: (QA follow-up) Tidy
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2024-01-10 18:10:07 UTC
Size:
2.36 KB
patch
obsolete
>From f667ac5212b47e128c3bd79d5e8190a31f1cb282 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 10 Jan 2024 18:09:31 +0000 >Subject: [PATCH] Bug 35757: (QA follow-up) Tidy > >--- > t/db_dependent/api/v1/erm_counter_registries.t | 4 ++-- > t/db_dependent/api/v1/erm_sushi_services.t | 6 +++--- > 2 files changed, 5 insertions(+), 5 deletions(-) > >diff --git a/t/db_dependent/api/v1/erm_counter_registries.t b/t/db_dependent/api/v1/erm_counter_registries.t >index e80f9e8dcf7..894fa76dc0b 100755 >--- a/t/db_dependent/api/v1/erm_counter_registries.t >+++ b/t/db_dependent/api/v1/erm_counter_registries.t >@@ -25,7 +25,7 @@ use Test::Mojo; > use t::lib::TestBuilder; > use t::lib::Mocks; > >-use JSON qw(encode_json); >+use JSON qw(encode_json); > use Array::Utils qw( array_minus ); > > use Koha::ERM::EUsage::CounterFiles; >@@ -85,7 +85,7 @@ subtest 'get() tests' => sub { > my $counter_registry = > $t->get_ok("//$userid:$password@/api/v1/erm/counter_registry?q=$q")->status_is(200)->tx->res->json; > >- my $registry_to_check = @$counter_registry[0]; >+ my $registry_to_check = @$counter_registry[0]; > my @response_fields = map { $_ } keys %$registry_to_check; > my @new_fields_in_response = array_minus( @response_fields, @expected_fields ); > >diff --git a/t/db_dependent/api/v1/erm_sushi_services.t b/t/db_dependent/api/v1/erm_sushi_services.t >index 0da48fa6e3b..8f254cb4355 100755 >--- a/t/db_dependent/api/v1/erm_sushi_services.t >+++ b/t/db_dependent/api/v1/erm_sushi_services.t >@@ -25,7 +25,7 @@ use Test::Mojo; > use t::lib::TestBuilder; > use t::lib::Mocks; > >-use JSON qw(encode_json); >+use JSON qw(encode_json); > use Array::Utils qw( array_minus ); > > use Koha::ERM::EUsage::CounterFiles; >@@ -96,8 +96,8 @@ subtest 'get() tests' => sub { > my $q = encode_json( { "url" => $service_url } ); > my $sushi_service = $t->get_ok("//$userid:$password@/api/v1/erm/sushi_service?q=$q")->status_is(200)->tx->res->json; > >- my @response_fields = map { $_ } keys %$sushi_service; >+ my @response_fields = map { $_ } keys %$sushi_service; > my @new_fields_in_response = array_minus( @response_fields, @expected_fields ); > >- is(scalar(@new_fields_in_response), 0, 'The response fields match the expected fields'); >+ is( scalar(@new_fields_in_response), 0, 'The response fields match the expected fields' ); > }; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35757
:
160745
|
160746
|
160747
|
160748
|
160749
|
160779
|
160780
| 160781