Bugzilla – Attachment 160849 Details for
Bug 35475
Untranslatable strings in booking modal and JS
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35475: Improve concatenated string and fix error in JS file
Bug-35475-Improve-concatenated-string-and-fix-erro.patch (text/plain), 1.89 KB, created by
Martin Renvoize
on 2024-01-11 14:18:20 UTC
(
hide
)
Description:
Bug 35475: Improve concatenated string and fix error in JS file
Filename:
MIME Type:
Creator:
Martin Renvoize
Created:
2024-01-11 14:18:20 UTC
Size:
1.89 KB
patch
obsolete
>From 0bda46563698101c89a31968300f199274e37029 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Sat, 23 Dec 2023 16:19:45 +0000 >Subject: [PATCH] Bug 35475: Improve concatenated string and fix error in JS > file > >Fixes 2 problems noted in comment#2 and comment#3 on the bug >report. > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/js/cancel_booking_modal.js | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt >index b72459c5f7f..63282f8f37f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt >@@ -90,7 +90,7 @@ > for (item of items[0]) { > itemsSet.add({ > id: item.item_id, >- content: _("Item") + " " + item.external_id, >+ content: _("Item %s").format(item.external_id), > }); > } > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/cancel_booking_modal.js b/koha-tmpl/intranet-tmpl/prog/js/cancel_booking_modal.js >index 4f993869ab5..3b325f0fc55 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/cancel_booking_modal.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/cancel_booking_modal.js >@@ -28,6 +28,6 @@ $("#cancelBookingForm").on('submit', function(e) { > }); > > deleting.fail(function(data) { >- $('#cancel_booking_result').replaceWith('<div id="booking_result" class="alert alert-danger">'+_("Failure")+'</div>'); >+ $('#cancel_booking_result').replaceWith('<div id="booking_result" class="alert alert-danger">'+__("Failure")+'</div>'); > }); > }); >-- >2.43.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35475
:
159704
|
160284
|
160285
|
160812
|
160813
|
160848
| 160849