Bugzilla – Attachment 160894 Details for
Bug 35322
AllowItemsOnHoldCheckoutSCO and AllowItemsOnHoldCheckoutSIP do not work
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35322: (QA follow-up) Perltidy
Bug-35322-QA-follow-up-Perltidy.patch (text/plain), 2.52 KB, created by
Emily Lamancusa (emlam)
on 2024-01-11 21:14:21 UTC
(
hide
)
Description:
Bug 35322: (QA follow-up) Perltidy
Filename:
MIME Type:
Creator:
Emily Lamancusa (emlam)
Created:
2024-01-11 21:14:21 UTC
Size:
2.52 KB
patch
obsolete
>From 6fb786769dee53c80ea24198593697fefb3838bf Mon Sep 17 00:00:00 2001 >From: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> >Date: Thu, 11 Jan 2024 15:43:49 -0500 >Subject: [PATCH] Bug 35322: (QA follow-up) Perltidy > >Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> >--- > t/db_dependent/Circulation.t | 16 ++++++++++++---- > 1 file changed, 12 insertions(+), 4 deletions(-) > >diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t >index f0c0e2ede9..5095afde73 100755 >--- a/t/db_dependent/Circulation.t >+++ b/t/db_dependent/Circulation.t >@@ -6138,8 +6138,10 @@ subtest 'Test CanBookBeIssued param ignore_reserves (Bug 35322)' => sub { > > my $homebranch = $builder->build( { source => 'Branch' } ); > my $holdingbranch = $builder->build( { source => 'Branch' } ); >- my $patron_1 = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } ); >- my $patron_2 = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } ); >+ my $patron_1 = $builder->build_object( >+ { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } ); >+ my $patron_2 = $builder->build_object( >+ { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } ); > > my $item = $builder->build_sample_item( > { >@@ -6182,11 +6184,17 @@ subtest 'Test CanBookBeIssued param ignore_reserves (Bug 35322)' => sub { > set_userenv($holdingbranch); > > my ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->barcode, undef, undef, 0 ); >- is( keys(%$error) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) ); >+ is( >+ keys(%$error) + keys(%$alerts), 0, >+ 'There should not be any errors or alerts (impossible)' . str( $error, $question, $alerts ) >+ ); > is( exists $question->{RESERVE_WAITING}, 1, 'RESERVE_WAITING is set' ); > > ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->barcode, undef, undef, 1 ); >- is( keys(%$error) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) ); >+ is( >+ keys(%$error) + keys(%$alerts), 0, >+ 'There should not be any errors or alerts (impossible)' . str( $error, $question, $alerts ) >+ ); > isnt( exists $question->{RESERVE_WAITING}, 1, 'RESERVE_WAITING is not set' ); > > }; >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35322
:
158886
|
159341
|
159510
|
159511
|
160892
|
160893
| 160894