Attachment 160905 Details for Bug 32477 – Bug 32477: Fix hiding all columns in item batch mod tools

[patch] Bug 32477: Fix hiding all columns in item batch mod tools

Bug-32477-Fix-hiding-all-columns-in-item-batch-mod.patch (text/plain), 2.20 KB, created by Jonathan Druart on 2024-01-12 09:42:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2024-01-12 09:42:36 UTC

Size: 2.20 KB

patch

obsolete

>From c7c3b4289e2dd521e8968022a7bf03a91dc434df Mon Sep 17 00:00:00 2001
>From: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
>Date: Fri, 22 Dec 2023 13:05:37 +0200
>Subject: [PATCH] Bug 32477: Fix hiding all columns in item batch mod tools
>
>If one hides all columns in batch item modification tool
>and then reloads the page or launches tool again, "Holds"
>column isn't displayed and "Itemtype" column is. Also
>"Itemtype" columns checkbox remains checked. This happens
>because "Itemtype" columns id is out of scope of list of column
>numbers set in cookies. This patch adds 3 to number of columns
>in variable "allColums" to take account all 3 columns we don't
>want to hide.
>
>To test:
>1. Find items to modify and modify them with batch item
>modification tool.
>2. Use "Hide all columns" checkbox to hide all columns.
>3. Confirm all columns expect checkbox, "Title" and "Holds"
>columns are hidden correctly.
>4. Reload the page.
>=> Note that "Holds" column is now hidden and "Itemtype"
>column is displayed. Also "Itemtype" checkbox is checked.
>5. Apply this patch.
>6. Repeat steps 1 to 4.
>=> "Holds" column should now be displayed and "Itemtype"
>hidden. None of the checkbox should be checked.
>
>Sponsored-by: Koha-Suomi Oy
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt
>index 0b43196fe13..0ee8dc54f15 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt
>@@ -272,7 +272,7 @@
>             // two to accommodate control and title columns
>             var allColumns = new Array([% FOREACH item_header_loo IN item_header_loop %]'[% loop.count | html %]'[% UNLESS ( loop.last ) %],[% END %][% END %]);
>             for( x=0; x<allColumns.length; x++ ){
>-                allColumns[x] = Number(allColumns[x]) + 2;
>+                allColumns[x] = Number(allColumns[x]) + 3;
>             }
> 
>             $(document).ready(function(){
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 32477: 159206 | 159249 | 159258 | 160230 | 160293 | 160294 | 160904 | 160905