Bugzilla – Attachment 160942 Details for
Bug 35676
OPAC search results - link for "Check for suggestions" generates a blank page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35676: Fix DidYouMean when not configured
Bug-35676-Fix-DidYouMean-when-not-configured.patch (text/plain), 2.24 KB, created by
Jonathan Druart
on 2024-01-12 12:50:54 UTC
(
hide
)
Description:
Bug 35676: Fix DidYouMean when not configured
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2024-01-12 12:50:54 UTC
Size:
2.24 KB
patch
obsolete
>From 887dcf8122bff47f48fb4cc8a1847b9dff66ba68 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 12 Jan 2024 13:46:50 +0100 >Subject: [PATCH] Bug 35676: Fix DidYouMean when not configured > >When DidYouMean is not configured, there is the following message >displayed: > "Not what you expected? Check for suggestions" >suggestions is a link to svc/suggestion which does not return content if >the feature is displayed > 90 unless ( @plugins ) { > 91 print $query->header; > 92 exit; > 93 } > >We should not see this text, it is supposed to be replaced when the ft >is enabled. > >However > commit 79bf4485c1b2ae8059e2ee15ea1e67bba9961c34 > Bug 34866: Use template wrapper for breadcrumbs: OPAC part 4 >made this change: >- [% IF ( DidYouMean ) %] >+ [% #IF ( DidYouMean ) %] > <div id="didyoumean">Not what you expected? Check for <a href="/cgi-bin/koha/svc/suggestion?render=standalone&q=[% querystring | uri %]">suggestions</a></div> >- [% END %] >+ [% #END %] > >Which is obviously wrong. > >Test plan: >Do not have the ft configured and launch a search (OPAC) that will not >return any results. >=> Without this patch there is the message >=> With this patch applied it is no longer displayed >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >index 702a6a60fc0..043b1bbc69c 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >@@ -122,9 +122,9 @@ > [% END # / IF searchdesc %] > > <div id="userresults"> >- [% #IF ( DidYouMean ) %] >+ [% IF ( DidYouMean ) %] > <div id="didyoumean">Not what you expected? Check for <a href="/cgi-bin/koha/svc/suggestion?render=standalone&q=[% querystring | uri %]">suggestions</a></div> >- [% #END %] >+ [% END %] > > [% IF ( koha_spsuggest ) %] > Did you mean: >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35676
:
160942
|
160962
|
160970