Bugzilla – Attachment 161010 Details for
Bug 35357
Item not removed from holds queue when checked out to a different patron
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35357: Remove item from holds queue when it is checked out
Bug-35357-Remove-item-from-holds-queue-when-it-is-.patch (text/plain), 1.36 KB, created by
Owen Leonard
on 2024-01-13 14:24:38 UTC
(
hide
)
Description:
Bug 35357: Remove item from holds queue when it is checked out
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2024-01-13 14:24:38 UTC
Size:
1.36 KB
patch
obsolete
>From 8e03e9f1c36e993a00e5fe4382e6901709a41d27 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 11 Jan 2024 09:31:45 -0500 >Subject: [PATCH] Bug 35357: Remove item from holds queue when it is checked > out > >Test Plan: >1) Place a hold on an item >2) Build the holds queue >3) Check out the item to a different patron than the one > targeted in the holds queue >4) Verify the holds queue viewer still shows that item and patron >5) Apply this patch >6) Repeat stepts 1 through 3 >7) Verify the holds queue viewer no longer shows that patron and item! > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > C4/Circulation.pm | 6 ++++++ > 1 file changed, 6 insertions(+) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 29abc95ac7..3a62f0af13 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -1729,6 +1729,12 @@ sub AddIssue { > %$issue_attributes, > } > )->store; >+ >+ # Ensure item is no longer listed in the holds queue >+ $dbh->do( >+ q{DELETE tmp_holdsqueue, hold_fill_targets FROM tmp_holdsqueue LEFT JOIN hold_fill_targets USING ( itemnumber ) WHERE itemnumber = ?}, >+ undef, $item_object->id >+ ); > } > $issue->discard_changes; > $patron->update_lastseen('check_out'); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35357
:
160851
|
160852
|
161009
|
161010
|
161789
|
161790
|
161791
|
161792
|
161849
|
161850
|
161851