Attachment 161019 Details for Bug 34234 – Bug 34234: Respect display_order in additem.tt and detail.tt

[patch] Bug 34234: Respect display_order in additem.tt and detail.tt

Bug-34234-Respect-displayorder-in-additemtt-and-de.patch (text/plain), 2.62 KB, created by David Nind on 2024-01-13 18:02:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2024-01-13 18:02:35 UTC

Size: 2.62 KB

patch

obsolete

>From 915b503dd2509605f3069439bbe11144b438ffa8 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Fri, 12 Jan 2024 17:35:24 +0000
>Subject: [PATCH] Bug 34234: Respect display_order in additem.tt and detail.tt
>
>1. APPLY PATCH
>2. EnableItemGroups
>3. Find a record and add some new item groups with display orders that are different from the order in which the groups were added
>4. Check the checkbox next to one or more items and click the link to "Add/move to item group"
>5. Ensure display order is correct
>6. Now add a new item to the record and scroll down to the dropdown underneath "+ Add to item group"
>7. Display order should be correct.
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt    | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>index ccdcb8ed25..ec10819c65 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>@@ -1247,7 +1247,7 @@
>                         <p>
>                             <label for="item_group" class="required">Item group: </label>
>                             <select name="item_group" id="item-group-add-form-select">
>-                                [% FOREACH ig IN biblio.item_groups %]
>+                                [% FOREACH ig IN biblio.item_groups.search({}, {order_by => 'display_order'}) %]
>                                     <option value="[% ig.id | html %]">[% ig.description | html %]</option>
>                                 [% END %]
>                             </select>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
>index 6fe0ec6cdc..cc951b72c1 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
>@@ -260,7 +260,7 @@
>             <label for="select_item_group">Options: </label>
>             <select name="item_group" id="item-group-add-or-create-form-select">
>                 <optgroup label="Use existing item group">
>-                    [% FOREACH ig IN item_groups %]
>+                    [% FOREACH ig IN biblio.item_groups.search({}, {order_by => 'display_order'}) %]
>                         <option value="[% ig.id | html %]">[% ig.description | html %]</option>
>                     [% END %]
>                 </optgroup>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34234: 158148 | 158294 | 158328 | 158329 | 160442 | 160542 | 160543 | 160992 | 161019 | 161760