Bugzilla – Attachment 16105 Details for
Bug 9212
Parentheses in subject headings break search
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 9212 - Parentheses in subject headings break search
Bug-9212---Parentheses-in-subject-headings-break-s.patch (text/plain), 2.89 KB, created by
Liz Rea
on 2013-03-14 08:07:03 UTC
(
hide
)
Description:
Bug 9212 - Parentheses in subject headings break search
Filename:
MIME Type:
Creator:
Liz Rea
Created:
2013-03-14 08:07:03 UTC
Size:
2.89 KB
patch
obsolete
>From f12e67553fb344a20b87512790925b0fcfa7c462 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Mon, 11 Mar 2013 13:06:44 -0400 >Subject: [PATCH] Bug 9212 - Parentheses in subject headings break search >Content-Type: text/plain; charset="utf-8" > >Subjects links for subjects with parentheses will not give any results. > >Test Plan: >1) In the OPAC, try clicking a subject link that contains parentheses, you should get an error >2) Apply the patch >3) Repeat step 1, this time it should work correctly. > >Signed-off-by: Liz Rea <liz@catalyst.net.nz> >Tested per plan, without the patch I didn't get the sort error, but I did get "result not found" >With the patch, I came back to my same record. I take this as an indicator that the patch is working. >--- > koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt | 2 +- > .../prog/en/xslt/MARC21slim2OPACDetail.xsl | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt >index 6321efd..fcf4aac 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt >@@ -665,7 +665,7 @@ YAHOO.util.Event.onContentReady("furtherm", function () { > <input type="checkbox" onclick="makeSubjectRequest()" > name="checkbox" > id="subject_[% subjectsloop.count %]_[% loop.count %]" >- value="su,wrdl:[% SUBFIELD.value |url %]" /> >+ value="su,wrdl:[% '"' _ SUBFIELD.value _ '"' | url %]" /> > <label for="subject_[% subjectsloop.count %]_[% loop.count %]"> > [% SUBFIELD.value %] > </label> >diff --git a/koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl >index 5130e8b..09e6665 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl >+++ b/koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl >@@ -519,7 +519,7 @@ > </xsl:attribute> > </xsl:when> > <xsl:otherwise> >- <xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=su<xsl:value-of select="$SubjectModifier"/>:<xsl:value-of select="$TracingQuotesLeft"/><xsl:value-of select="marc:subfield[@code='a']"/><xsl:value-of select="$TracingQuotesRight"/></xsl:attribute> >+ <xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=su<xsl:value-of select="$SubjectModifier"/>:<xsl:value-of select="$TracingQuotesLeft"/>"<xsl:value-of select="marc:subfield[@code='a']"/>"<xsl:value-of select="$TracingQuotesRight"/></xsl:attribute> > </xsl:otherwise> > </xsl:choose> > <xsl:call-template name="chopPunctuation"> >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9212
:
13887
|
16043
| 16105