Bugzilla – Attachment 161058 Details for
Bug 35813
When placing a booking, we should feedback successful placements
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35813: Add success feedback after placing/editing bookings
Bug-35813-Add-success-feedback-after-placingeditin.patch (text/plain), 5.68 KB, created by
Owen Leonard
on 2024-01-16 12:22:43 UTC
(
hide
)
Description:
Bug 35813: Add success feedback after placing/editing bookings
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2024-01-16 12:22:43 UTC
Size:
5.68 KB
patch
obsolete
>From 0b7a3bab7b850a59ea08c033b9f3809c9c598b50 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Mon, 15 Jan 2024 16:45:03 +0000 >Subject: [PATCH] Bug 35813: Add success feedback after placing/editing > bookings > >This patch restores the lost behaviour that a successful add/edit of a >booking via the 'Place booking' modal should notify the end user that >the submission was sucessful. > >Test plan >1) Set an item as bookable to expose the 'Place booking' button >2) Place a new booking from the following pages and confirm that you > now recieve feedback. > * Catalog > Title > Details > * Catalog > Title > MARC details > * Catalog > Title > ISBD details > * Catalog > Title > Item details > * Catalog > Title > Bookings >3) Edit a booking on the 'Catalog > Title > Bookings' page and confirm > you now recieve feedback. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > .../intranet-tmpl/prog/en/modules/bookings/list.tt | 1 + > .../prog/en/modules/catalogue/ISBDdetail.tt | 1 + > .../prog/en/modules/catalogue/MARCdetail.tt | 1 + > .../intranet-tmpl/prog/en/modules/catalogue/detail.tt | 1 + > .../prog/en/modules/catalogue/moredetail.tt | 4 ++-- > koha-tmpl/intranet-tmpl/prog/js/place_booking_modal.js | 10 ++++++++-- > 6 files changed, 14 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt >index 63282f8f37..cc241034bc 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt >@@ -32,6 +32,7 @@ > <div class="col-sm-10 col-sm-push-2"> > <main> > <div class="row"> >+ <div id="transient_result"></div> > [% INCLUDE 'cat-toolbar.inc' %] > <h1>Bookings for [% INCLUDE 'biblio-title-head.inc' %]</h1> > <div class="page-section" id="bookings-timeline"></div> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/ISBDdetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/ISBDdetail.tt >index b2e706b3ca..d9deb23895 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/ISBDdetail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/ISBDdetail.tt >@@ -47,6 +47,7 @@ > <div class="row"> > <div class="col-sm-10 col-sm-push-2"> > <main> >+ <div id="transient_result"></div> > [% INCLUDE 'cat-toolbar.inc' %] > <h1> > [% IF ( unknownbiblionumber ) %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt >index 3575bec9c7..8efb6891e8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt >@@ -54,6 +54,7 @@ > <div class="dialog message">The record you requested does not exist ([% biblionumber | html %]).</div> > [% ELSE %] > >+<div id="transient_result"></div> > [% INCLUDE 'cat-toolbar.inc' %] > > [% UNLESS ( popup ) %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >index ccdcb8ed25..0903be51aa 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >@@ -91,6 +91,7 @@ > [% CoceHost = Koha.Preference('CoceHost') %] > [% SyndeticsCovers = Koha.Preference('SyndeticsEnabled') && Koha.Preference('SyndeticsCoverImages') %] > >+<div id="transient_result"></div> > [% INCLUDE 'cat-toolbar.inc' %] > [% IF ( ocoins ) %] > <!-- COinS / OpenURL --> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt >index ad31298807..0619a8b0fb 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt >@@ -41,11 +41,11 @@ > <div class="row"> > <div class="col-sm-10 col-sm-push-2"> > <main> >+ <div id="transient_result"></div> >+ [% INCLUDE 'cat-toolbar.inc' %] > > <h1>Item details for [% INCLUDE 'biblio-title-head.inc' %]</h1> > >- [% INCLUDE 'cat-toolbar.inc' %] >- > <div id="catalogue_detail_biblio"> > <div class="page-section clearfix"> > <h2>[% title | html %]</h2> >diff --git a/koha-tmpl/intranet-tmpl/prog/js/place_booking_modal.js b/koha-tmpl/intranet-tmpl/prog/js/place_booking_modal.js >index b4f13bf2d9..166958bb6b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/place_booking_modal.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/place_booking_modal.js >@@ -488,7 +488,10 @@ $("#placeBookingForm").on('submit', function(e) { > > // Update bookings counts > $('.bookings_count').html(parseInt($('.bookings_count').html(), 10)+1); >- >+ >+ // Set feedback >+ $('#transient_result').replaceWith('<div id="transient_result" class="dialog success">'+_("Booking successfully placed")+'</div>'); >+ > // Close modal > $('#placeBookingModal').modal('hide'); > }); >@@ -539,7 +542,10 @@ $("#placeBookingForm").on('submit', function(e) { > }); > timeline.focus(data.booking_id); > } >- >+ >+ // Set feedback >+ $('#transient_result').replaceWith('<div id="transient_result" class="dialog success">'+_("Booking successfully updated")+'</div>'); >+ > // Close modal > $('#placeBookingModal').modal('hide'); > }); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35813
:
161048
|
161058
|
161059
|
161086
|
161087
|
162263
|
162264
|
162265
|
163561
|
163562
|
163563
|
166579
|
166580
|
166581