Attachment 161060 Details for Bug 35817 – Bug 35817: Fix hint on patron's category when batch update patron

[patch] Bug 35817: Fix hint on patron's category when batch update patron

Bug-35817-Fix-hint-on-patrons-category-when-batch-.patch (text/plain), 1.59 KB, created by Jonathan Druart on 2024-01-16 12:44:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2024-01-16 12:44:05 UTC

Size: 1.59 KB

patch

obsolete

>From 2e49e42380103548eaedff9f00a5433fc22a1ad5 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 16 Jan 2024 13:41:59 +0100
>Subject: [PATCH] Bug 35817: Fix hint on patron's category when batch update
> patron
>
>When a patron's attribute is limited to a given patron's category, the batch patron modification tool will display a hint "This attribute will be only applied to the patron's category %s". But this is followed by the description of the patron's attribute, not the patron's category.
>
>Test plan:
>Create a patron's attribute "Color of hair" and select a patron
>category (Patron).
>Batch edit batch and select "Color of hair"
>A hint will be display.
>=> Without this patch the hint is "This attribute will be only applied to the patron's category Color of hair"
>=> With this patch it will be corrected to "This attribute will be only applied to the patron's category Patron"
>---
> tools/modborrowers.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/tools/modborrowers.pl b/tools/modborrowers.pl
>index 36c893b4163..4b9c7146d8c 100755
>--- a/tools/modborrowers.pl
>+++ b/tools/modborrowers.pl
>@@ -148,7 +148,7 @@ if ( $op eq 'show' ) {
> 
>         my $category_code = $attr_type->category_code;
>         my ( $category_lib ) = map {
>-            ( defined $category_code and $attr_type->category_code eq $category_code ) ? $attr_type->description : ()
>+            ( defined $category_code and $attr_type->category_code eq $_->categorycode ) ? $_->description : ()
>         } @patron_categories;
>         push @patron_attributes_codes,
>             {
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 35817: 161060 | 161063 | 161493 | 161506