Attachment 161070 Details for Bug 34853 – Bug 34853: Switch to 'div' as suggested

[patch] Bug 34853: Switch to 'div' as suggested

Bug-34853-Switch-to-div-as-suggested.patch (text/plain), 2.15 KB, created by Martin Renvoize (ashimema) on 2024-01-16 17:13:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-01-16 17:13:21 UTC

Size: 2.15 KB

patch

obsolete

>From 35d7ddf36eeef7c4b1224aa7bb0e5f4542c69adf Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Tue, 16 Jan 2024 17:11:23 +0000
>Subject: [PATCH] Bug 34853: Switch to 'div' as suggested
>
>This patch switches us from '<span class="clearfix">' to '<div>' so
>we're just using a block level elemenet instead of manipulating an
>inline element to act like a block.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> .../intranet-tmpl/prog/en/modules/catalogue/detail.tt     | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>index b97c2c8b996..e62947eda7a 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>@@ -857,15 +857,15 @@
>             <td>
>             [% IF order.invoiceid %]
>                 [% IF CAN_user_acquisition %]
>-                    <span class="clearfix"><a href="/cgi-bin/koha/acqui/invoice.pl?invoiceid=[% order.invoiceid | uri %]"
>+                    <div><a href="/cgi-bin/koha/acqui/invoice.pl?invoiceid=[% order.invoiceid | uri %]"
>                        title="Invoice detail page">
>-                       [% order.invoice.invoicenumber | html %]</a></span>
>+                       [% order.invoice.invoicenumber | html %]</a></div>
>                 [% ELSE %]
>-                    <span class="clearfix">[% order.invoice.invoicenumber | html %]</span>
>+                    <div>[% order.invoice.invoicenumber | html %]</div>
>                 [% END %]
> 
>                 [% IF ( Koha.Preference('EDIFACT') && CAN_user_acquisition_edi_manage && order.invoice.message_id ) %]
>-                    <span class="clearfix"><a href="/cgi-bin/koha/acqui/edimsg.pl?id=[% order.invoice.message_id | uri %]" title="EDI INVOICE message">EDI message</a></span>
>+                    <div><a href="/cgi-bin/koha/acqui/edimsg.pl?id=[% order.invoice.message_id | uri %]" title="EDI INVOICE message">EDI message</a></div>
>                 [% END %]
>             [% END %]
>             </td>
>-- 
>2.43.0

Actions: View | Diff | Splinter Review

Attachments on bug 34853: 155953 | 155954 | 161069 | 161070