Bugzilla – Attachment 161072 Details for
Bug 35535
Cancel hold -button does not work in pop-up (Hold found, item is already waiting)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35535: Do not pass value of NULL on returns.tt when cancelling hold
Bug-35535-Do-not-pass-value-of-NULL-on-returnstt-w.patch (text/plain), 1.78 KB, created by
Lucas Gass (lukeg)
on 2024-01-16 18:13:27 UTC
(
hide
)
Description:
Bug 35535: Do not pass value of NULL on returns.tt when cancelling hold
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2024-01-16 18:13:27 UTC
Size:
1.78 KB
patch
obsolete
>From 6d7529abbc4155b10969f4c1edf7fad66fab5b52 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Tue, 16 Jan 2024 18:11:50 +0000 >Subject: [PATCH] Bug 35535: Do not pass value of NULL on returns.tt when > cancelling hold > >To test: >1. APPLY PATCH >2. Check in an item having awaiting hold there comes a pop-up window. There is a button saying Cancel hold. >3. Cancel the hold without giving a reason. >4. Check that the hold has been properly canceled. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >index 2abde7f9c5..43b83af66c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >@@ -705,7 +705,7 @@ > [% SET hold_cancellation = AuthorisedValues.GetAuthValueDropbox('HOLD_CANCELLATION') %] > [% IF hold_cancellation.count %] > <select name="cancellation-reason" id="cancellation-reason"> >- <option value="NULL">No reason given</option> >+ <option value="">No reason given</option> > [% FOREACH reason IN hold_cancellation %] > <option value="[% reason.authorised_value | html %]">[% reason.lib | html %]</option> > [% END %] >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35535
:
161072
|
161112
|
161113
|
161449