Bugzilla – Attachment 161074 Details for
Bug 35107
ILL - Type disclaimer value and date should be visible under "Request details" in the manage request page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35107: (QA follow-up) Use extended_attributes
Bug-35107-QA-follow-up-Use-extendedattributes.patch (text/plain), 1.38 KB, created by
Kyle M Hall (khall)
on 2024-01-16 19:30:39 UTC
(
hide
)
Description:
Bug 35107: (QA follow-up) Use extended_attributes
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2024-01-16 19:30:39 UTC
Size:
1.38 KB
patch
obsolete
>From c33d69b6e4b58041c806dd456a03abfde12a6167 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Mon, 27 Nov 2023 14:31:30 +0000 >Subject: [PATCH] Bug 35107: (QA follow-up) Use extended_attributes > >Addressing the warning: >illrequestattributes is DEPRECATED in favor of extended_attributes > >No functional behaviour change here > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > Koha/Illrequest.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/Koha/Illrequest.pm b/Koha/Illrequest.pm >index c69915896f0..940d66e6c5e 100644 >--- a/Koha/Illrequest.pm >+++ b/Koha/Illrequest.pm >@@ -1113,7 +1113,7 @@ Return the value submitted in the type disclaimer workflow stage > > sub get_type_disclaimer_value { > my ($self) = @_; >- my $attr = $self->illrequestattributes->find( { type => 'type_disclaimer_value' } ); >+ my $attr = $self->extended_attributes->find( { type => 'type_disclaimer_value' } ); > return if !$attr; > return $attr->value; > } >@@ -1128,7 +1128,7 @@ Return the time the disclaimer was submitted in the type disclaimer workflow sta > > sub get_type_disclaimer_date { > my ($self) = @_; >- my $attr = $self->illrequestattributes->find( { type => 'type_disclaimer_date' } ); >+ my $attr = $self->extended_attributes->find( { type => 'type_disclaimer_date' } ); > return if !$attr; > return $attr->value; > } >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35107
:
157438
|
158072
|
159271
|
159272
|
161073
| 161074 |
161075
|
163795