Attachment 161086 Details for Bug 35813 – Bug 35813: Add success feedback after placing/editing bookings

[patch] Bug 35813: Add success feedback after placing/editing bookings

Bug-35813-Add-success-feedback-after-placingeditin.patch (text/plain), 5.69 KB, created by Martin Renvoize (ashimema) on 2024-01-17 10:31:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-01-17 10:31:54 UTC

Size: 5.69 KB

patch

obsolete

>From 9195757e2f1088c936df340d46f54828e63dc605 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Mon, 15 Jan 2024 16:45:03 +0000
>Subject: [PATCH] Bug 35813: Add success feedback after placing/editing
> bookings
>
>This patch restores the lost behaviour that a successful add/edit of a
>booking via the 'Place booking' modal should notify the end user that
>the submission was sucessful.
>
>Test plan
>1) Set an item as bookable to expose the 'Place booking' button
>2) Place a new booking from the following pages and confirm that you
>   now recieve feedback.
>   * Catalog > Title > Details
>   * Catalog > Title > MARC details
>   * Catalog > Title > ISBD details
>   * Catalog > Title > Item details
>   * Catalog > Title > Bookings
>3) Edit a booking on the 'Catalog > Title > Bookings' page and confirm
>   you now recieve feedback.
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> .../intranet-tmpl/prog/en/modules/bookings/list.tt     |  1 +
> .../prog/en/modules/catalogue/ISBDdetail.tt            |  1 +
> .../prog/en/modules/catalogue/MARCdetail.tt            |  1 +
> .../intranet-tmpl/prog/en/modules/catalogue/detail.tt  |  1 +
> .../prog/en/modules/catalogue/moredetail.tt            |  4 ++--
> koha-tmpl/intranet-tmpl/prog/js/place_booking_modal.js | 10 ++++++++--
> 6 files changed, 14 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt
>index a8f51d3e197..a259ad863eb 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt
>@@ -38,6 +38,7 @@
>         <div class="col-sm-10 col-sm-push-2">
>             <main>
>                 <div class="row">
>+                    <div id="transient_result"></div>
>                     [% INCLUDE 'cat-toolbar.inc' %]
>                     <h1>Bookings for [% INCLUDE 'biblio-title-head.inc' %]</h1>
>                     <div class="page-section" id="bookings-timeline"></div>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/ISBDdetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/ISBDdetail.tt
>index b2e706b3ca3..d9deb23895b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/ISBDdetail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/ISBDdetail.tt
>@@ -47,6 +47,7 @@
>     <div class="row">
>         <div class="col-sm-10 col-sm-push-2">
>             <main>
>+            <div id="transient_result"></div>
>             [% INCLUDE 'cat-toolbar.inc' %]
>                 <h1>
>                     [% IF ( unknownbiblionumber ) %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt
>index 3575bec9c7d..8efb6891e8b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt
>@@ -54,6 +54,7 @@
>   <div class="dialog message">The record you requested does not exist ([% biblionumber | html %]).</div>
> [% ELSE %]
> 
>+<div id="transient_result"></div>
> [% INCLUDE 'cat-toolbar.inc' %]
> 
> [% UNLESS ( popup ) %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>index 8f1f9c2d746..3a6e0d75675 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>@@ -91,6 +91,7 @@
> [% CoceHost        = Koha.Preference('CoceHost') %]
> [% SyndeticsCovers = Koha.Preference('SyndeticsEnabled') && Koha.Preference('SyndeticsCoverImages') %]
> 
>+<div id="transient_result"></div>
> [% INCLUDE 'cat-toolbar.inc' %]
>     [% IF ( ocoins ) %]
>         
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt
>index ad312988073..0619a8b0fbd 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt
>@@ -41,11 +41,11 @@
>     <div class="row">
>         <div class="col-sm-10 col-sm-push-2">
>             <main>
>+                <div id="transient_result"></div>
>+                [% INCLUDE 'cat-toolbar.inc' %]
> 
>                 <h1>Item details for [% INCLUDE 'biblio-title-head.inc' %]</h1>
> 
>-                [% INCLUDE 'cat-toolbar.inc' %]
>-
>                 <div id="catalogue_detail_biblio">
>                     <div class="page-section clearfix">
>                         <h2>[% title | html %]</h2>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/place_booking_modal.js b/koha-tmpl/intranet-tmpl/prog/js/place_booking_modal.js
>index b4f13bf2d99..166958bb6bb 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/place_booking_modal.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/place_booking_modal.js
>@@ -488,7 +488,10 @@ $("#placeBookingForm").on('submit', function(e) {
>     
>             // Update bookings counts
>             $('.bookings_count').html(parseInt($('.bookings_count').html(), 10)+1);
>-    
>+
>+            // Set feedback
>+            $('#transient_result').replaceWith('<div id="transient_result" class="dialog success">'+_("Booking successfully placed")+'</div>');
>+
>             // Close modal
>             $('#placeBookingModal').modal('hide');
>         });
>@@ -539,7 +542,10 @@ $("#placeBookingForm").on('submit', function(e) {
>                 });
>                 timeline.focus(data.booking_id);
>             }
>-    
>+
>+            // Set feedback
>+            $('#transient_result').replaceWith('<div id="transient_result" class="dialog success">'+_("Booking successfully updated")+'</div>');
>+
>             // Close modal
>             $('#placeBookingModal').modal('hide');
>         });
>-- 
>2.43.0

Actions: View | Diff | Splinter Review

Attachments on bug 35813: 161048 | 161058 | 161059 | 161086 | 161087 | 162263 | 162264 | 162265 | 163561 | 163562 | 163563 | 166579 | 166580 | 166581