Attachment 161123 Details for Bug 35300 – Bug 35300: Add page-section to invoice files page

[patch] Bug 35300: Add page-section to invoice files page

Bug-35300-Add-page-section-to-invoice-files-page.patch (text/plain), 4.23 KB, created by Lucas Gass (lukeg) on 2024-01-17 22:47:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2024-01-17 22:47:15 UTC

Size: 4.23 KB

patch

obsolete

>From 21581a253cab95e1769fb130e4181967700f93c3 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Sat, 6 Jan 2024 19:57:04 +0000
>Subject: [PATCH] Bug 35300: Add page-section to invoice files page
>
>To test:
>* Enable AcqEnableFiles system preference
>* Go to acquisitions
>* Search for a vendor and receive shipment
>* Enter an invoice number and create new invoice
>* Finish receive
>* Click on 'manage invice files' link
>* Upload a sample file
>* Verify the table is missing the usual white background
>* Apply patch
>* Verify the the table now displays with the usual white
>  background
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>---
> .../prog/en/modules/acqui/invoice-files.tt    | 58 ++++++++++---------
> 1 file changed, 30 insertions(+), 28 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice-files.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice-files.tt
>index 7411687e6f..2734388f91 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice-files.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice-files.tt
>@@ -51,34 +51,36 @@
>         </div>
>       [% END %]
>       [% IF files %]
>-          <table id="invoice_files_details_table">
>-              <thead>
>-                  <tr>
>-                      <th>Name</th>
>-                      <th>Type</th>
>-                      <th>Description</th>
>-                      <th>Uploaded</th>
>-                      <th>Bytes</th>
>-                      <th>&nbsp;</th>
>-                      <th>&nbsp;</th>
>-                  </tr>
>-              </thead>
>-              <tbody>
>-                [% FOREACH f IN files %]
>-                  <tr>
>-                      <td><a href="?invoiceid=[% invoiceid | uri %]&amp;op=download&amp;view=1&amp;file_id=[% f.file_id | uri %]">[% f.file_name | html %]</a></td>
>-                      <td>[% f.file_type | html %]</td>
>-                      <td>[% f.file_description | html %]</td>
>-                      <td data-order="[% f.date_uploaded | html %]">
>-                        [% f.date_uploaded | $KohaDates %]
>-                      </td>
>-                      <td>[% f.file_size | html %]</td>
>-                      <td><a class="delete_file" href="?invoiceid=[% invoiceid | html %]&amp;op=delete&amp;file_id=[% f.file_id | html %]">Delete</a></td>
>-                      <td><a href="?invoiceid=[% invoiceid | uri %]&amp;op=download&amp;file_id=[% f.file_id | uri %]">Download</a></td>
>-                  </tr>
>-                [% END %]
>-              </tbody>
>-          </table>
>+          <div class="page-section">
>+              <table id="invoice_files_details_table">
>+                  <thead>
>+                      <tr>
>+                          <th>Name</th>
>+                          <th>Type</th>
>+                          <th>Description</th>
>+                          <th>Uploaded</th>
>+                          <th>Bytes</th>
>+                          <th>&nbsp;</th>
>+                          <th>&nbsp;</th>
>+                      </tr>
>+                  </thead>
>+                  <tbody>
>+                    [% FOREACH f IN files %]
>+                      <tr>
>+                          <td><a href="?invoiceid=[% invoiceid | uri %]&amp;op=download&amp;view=1&amp;file_id=[% f.file_id | uri %]">[% f.file_name | html %]</a></td>
>+                          <td>[% f.file_type | html %]</td>
>+                          <td>[% f.file_description | html %]</td>
>+                          <td data-order="[% f.date_uploaded | html %]">
>+                            [% f.date_uploaded | $KohaDates %]
>+                          </td>
>+                          <td>[% f.file_size | html %]</td>
>+                          <td><a class="delete_file" href="?invoiceid=[% invoiceid | html %]&amp;op=delete&amp;file_id=[% f.file_id | html %]">Delete</a></td>
>+                          <td><a href="?invoiceid=[% invoiceid | uri %]&amp;op=download&amp;file_id=[% f.file_id | uri %]">Download</a></td>
>+                      </tr>
>+                    [% END %]
>+                  </tbody>
>+              </table>
>+            </div>
>       [% ELSE %]
>           <div class="dialog message">
>               <p>This invoice has no files attached.</p>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 35300: 160603 | 160612 | 161123