Bugzilla – Attachment 161204 Details for
Bug 34298
Duplicate existing orders is missing page section on order list
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34298: Add page-section to duplicated orders list
Bug-34298-Add-page-section-to-duplicated-orders-li.patch (text/plain), 3.60 KB, created by
Marcel de Rooy
on 2024-01-19 10:46:58 UTC
(
hide
)
Description:
Bug 34298: Add page-section to duplicated orders list
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2024-01-19 10:46:58 UTC
Size:
3.60 KB
patch
obsolete
>From 473b9ffe48f935b4848ddd8a250cd9b6f5718247 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Sat, 13 Jan 2024 17:54:32 +0000 >Subject: [PATCH] Bug 34298: Add page-section to duplicated orders list >Content-Type: text/plain; charset=utf-8 > >When creating an order from an existing order (copy), >on the third page, the page section was missing on the >table. > >To test: >* Create a basket with an order, close the basket. >* Create a second basked >* Create a new order line using: > "From existing orders (copy)" >* Search for your previous order and select it for copy - Next >* Select a fund - Duplicate orders >* Verify that the table with the order lines to create > doesn't have the white background >* Apply patch >* Reload page - the table now should appear styled correctly > >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > .../prog/en/modules/acqui/duplicate_orders.tt | 52 ++++++++++--------- > 1 file changed, 27 insertions(+), 25 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/duplicate_orders.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/duplicate_orders.tt >index e069fe6e60..da28c3b83c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/duplicate_orders.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/duplicate_orders.tt >@@ -264,31 +264,33 @@ > > [% ELSIF op == 'duplication_done' %] > [% IF new_orders %] >- <table id="table_neworders"> >- <thead> >- <tr> >- <th>Order line</th> >- <th>Status</th> >- <th>Basket</th> >- <th>Basket creator</th> >- <th>Basket group</th> >- <th>Invoice number</th> >- <th class="anti-the">Summary</th> >- <th>Vendor</th> >- <th>Placed on</th> >- <th>Received on</th> >- <th>Quantity received</th> >- <th>Quantity ordered</th> >- <th>Unit cost</th> >- <th>Fund</th> >- </tr> >- </thead> >- <tbody> >- [% FOREACH order IN new_orders %] >- [% INCLUDE display_order_line %] >- [% END %] >- </tbody> >- </table> >+ <div class="page-section"> >+ <table id="table_neworders"> >+ <thead> >+ <tr> >+ <th>Order line</th> >+ <th>Status</th> >+ <th>Basket</th> >+ <th>Basket creator</th> >+ <th>Basket group</th> >+ <th>Invoice number</th> >+ <th class="anti-the">Summary</th> >+ <th>Vendor</th> >+ <th>Placed on</th> >+ <th>Received on</th> >+ <th>Quantity received</th> >+ <th>Quantity ordered</th> >+ <th>Unit cost</th> >+ <th>Fund</th> >+ </tr> >+ </thead> >+ <tbody> >+ [% FOREACH order IN new_orders %] >+ [% INCLUDE display_order_line %] >+ [% END %] >+ </tbody> >+ </table> >+ </div> > <a class="btn btn-default" href="/cgi-bin/koha/acqui/basket.pl?basketno=[% basket.basketno | html %]"><i class="fa fa-fw fa-arrow-left"></i> Return to the basket</a > [% ELSE %] > <span>No order has been duplicated. Maybe something wrong happened?</span> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34298
:
161018
|
161119
| 161204