Bugzilla – Attachment 161217 Details for
Bug 35840
Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35840: Only AddReturn if item is onloan
Bug-35840-Only-AddReturn-if-item-is-onloan.patch (text/plain), 1.49 KB, created by
Biblibre Sandboxes
on 2024-01-19 16:08:18 UTC
(
hide
)
Description:
Bug 35840: Only AddReturn if item is onloan
Filename:
MIME Type:
Creator:
Biblibre Sandboxes
Created:
2024-01-19 16:08:18 UTC
Size:
1.49 KB
patch
obsolete
>From 615e120752d43cdf828e12fa98186c45f4e6b3e8 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Fri, 19 Jan 2024 15:27:24 +0000 >Subject: [PATCH] Bug 35840: Only AddReturn if item is onloan > >To test: >1. APPLY PATCH, restart_all >2. Turn on RecordLocalUseOnReturn >3. Create a Statistical patron. >4. Check an item out to a regular patron. >5. Check the item out to a Statistical patron. >6. This should trigger a return and you will see 2 entries in the statistics table, one for localuse and one for a return. >7. Try checking out an item to the Stats patron that is NOT checked out. >8. You should only see 1 entry, localuse, in the statistics table. > >Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> >--- > C4/Circulation.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 109809d4b9..81b7a30627 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -836,7 +836,7 @@ sub CanBookBeIssued { > ); > my $block_lost_return = C4::Context->preference("BlockReturnOfLostItems") ? 1 : 0; > my ( $stats_return, $stats_messages, $stats_iteminformation, $stats_borrower ) = >- AddReturn( $item_object->barcode, C4::Context->userenv->{'branch'} ); >+ AddReturn( $item_object->barcode, C4::Context->userenv->{'branch'} ) unless !$item_object->onloan; > ModDateLastSeen( $item_object->itemnumber, $block_lost_return ); # FIXME Move to Koha::Item > return ( > { >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35840
:
161212
|
161217
|
161223
|
161374
|
161442
|
161443
|
161612
|
161613
|
161614
|
161732
|
161733
|
162963
|
162964
|
162965