Attachment 161222 Details for Bug 35769 – Bug 35769: Fix untranslatable strings in request.tt

[patch] Bug 35769: Fix untranslatable strings in request.tt

Bug-35769-Fix-untranslatable-strings-in-requesttt.patch (text/plain), 2.60 KB, created by David Nind on 2024-01-19 20:23:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2024-01-19 20:23:49 UTC

Size: 2.60 KB

patch

obsolete

>From b691d3a0a07ab503e61406db53dceba70b34cc31 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Fri, 12 Jan 2024 22:52:42 +0000
>Subject: [PATCH] Bug 35769: Fix untranslatable strings in request.tt
>
>This fixes some strings in the JavaScript part of the
>template that were missing from the po files.
>
>This is one way to test:
>* Apply patch
>* Run gulp po:update --lang <language-code>
>* Compare strings changed in the patch, with strings
>  appearing in <language-code>-staff-prog.po
>* Translate the strings and remove "fuzzy" line
>* In k-t-d, run:
>  sudo koha-translate --install <language-code> --dev <instance>
>* Verify that now the translated version of the template contains
>  your translated strings
>* Verify the translated page works correctly, no errors
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> .../intranet-tmpl/prog/en/modules/reserve/request.tt      | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>index c29439bf01..07150eb36e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>@@ -1509,7 +1509,7 @@
>                                 .closest('tr')
>                                 .find(".pickup_locations").val() === null) {
> 
>-                        msg = _("- Please select a pickup location for the item" + "\n")
>+                        msg = (_("- Please select a pickup location for the item") + "\n");
>                     }
>                 }
>                 else {
>@@ -1517,7 +1517,7 @@
>                 }
>             } else {
>                 if( $("#pickup").length < 1 || $("#pickup").val() == "" || $('#pickup').val() === null ){
>-                    msg = _("- Please select a pickup location for this hold" + "\n");
>+                    msg = (_("- Please select a pickup location for this hold") + "\n");
>                 }
>             }
> 
>@@ -1549,12 +1549,12 @@
>                     }
>                 });
>                 if ( pickup_not_set > 0 ) {
>-                    alert( _("Please make sure all selected titles have a pickup location set" + "\n") );
>+                    alert( _("Please make sure all selected titles have a pickup location set") + "\n" );
>                     return false;
>                 }
>             }
>             else {
>-                alert( _("Please select at least one title" + "\n") );
>+                alert( _("Please select at least one title") + "\n" );
>                 return false;
>             }
> 
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 35769: 160797 | 161011 | 161222 | 161312 | 161346