Attachment 161316 Details for Bug 35800 – Bug 35800: Remove item.can.be.edited check

[patch] Bug 35800: Remove item.can.be.edited check

Bug-35800-Remove-itemcanbeedited-check.patch (text/plain), 2.86 KB, created by Caroline Cyr La Rose on 2024-01-23 19:50:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Caroline Cyr La Rose

Created: 2024-01-23 19:50:44 UTC

Size: 2.86 KB

patch

obsolete

>From 0dae9c7d9bf91d08560dcda3308560996b92b312 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Tue, 23 Jan 2024 17:53:39 +0000
>Subject: [PATCH] Bug 35800: Remove item.can.be.edited check
>
>To test:
>APPLY PATCH
>1. Check out an item to a patron from library A
>2. Give permissions to a patron from library B
>   (example of a circulation staff account)
>     - circulate
>     - catalogue
>     - borrowers ( including view_borrower_infos_from_any_libraries )
>     - reserveforothers
>     - updatecharges
>     - suggestions
>     - lists
>     - clubs -> enroll
>3. If necessary, change the username and password of that staff member in order to be able to log in
>4. In a private browser window, log in as the staff member
>5. View the record with the checked out item
>6. You should see the name/cardnumber of the patron the item is checked out ot.
>7. Turn off the view_borrower_infos_from_any_libraries for this patron.
>8. Now on the record detail page you should see text like `Checked out to A patron from library Midway : due 01/28/2024`.
>
>Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
>---
> .../prog/en/modules/catalogue/detail.tt          | 16 +++++++---------
> 1 file changed, 7 insertions(+), 9 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>index 8f1f9c2d74..a8b2bc364d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>@@ -475,15 +475,13 @@
>                           [% ELSE %]
>                             <div class="item_status datedue">Checked out
>                           [% END %]
>-                                [% IF item.can_be_edited %]
>-                                  [% IF item.object.checkout.onsite_checkout %]
>-                                    by
>-                                  [% ELSE %]
>-                                    to
>-                                  [% END %]
>-                                  [% INCLUDE 'patron-title.inc' patron=item.object.checkout.patron hide_patron_infos_if_needed=1 %]
>-                                [% END %]
>-                                : due [% date_due | $KohaDates as_due_date => 1 %]
>+                              [% IF item.object.checkout.onsite_checkout %]
>+                                by
>+                              [% ELSE %]
>+                                to
>+                              [% END %]
>+                              [% INCLUDE 'patron-title.inc' patron=item.object.checkout.patron hide_patron_infos_if_needed=1 %]
>+                            : due [% date_due | $KohaDates as_due_date => 1 %]
>                             </div>
>                         [% ELSIF ( transfer = item.object.get_transfer ) %]
>                             [% IF (transfer.datesent) %]
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 35800: 161313 | 161316 | 161508