Bugzilla – Attachment 161377 Details for
Bug 35904
C4::Auth::checkauth cannot be tested easily
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35904: Remove var loggedin
Bug-35904-Remove-var-loggedin.patch (text/plain), 1.35 KB, created by
Jonathan Druart
on 2024-01-25 09:41:10 UTC
(
hide
)
Description:
Bug 35904: Remove var loggedin
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2024-01-25 09:41:10 UTC
Size:
1.35 KB
patch
obsolete
>From 142935a6a43cf9d35cd570f8a48ae17dbe065bcb Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 24 Jan 2024 16:24:51 +0100 >Subject: [PATCH] Bug 35904: Remove var loggedin > >It is never used and add confusion >--- > C4/Auth.pm | 3 --- > 1 file changed, 3 deletions(-) > >diff --git a/C4/Auth.pm b/C4/Auth.pm >index c449c318a92..207f9328bbf 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -814,7 +814,6 @@ sub checkauth { > _version_check( $type, $query ); > > # state variables >- my $loggedin = 0; > my $auth_state = 'failed'; > my %info; > my ( $userid, $cookie, $sessionID, $flags ); >@@ -854,7 +853,6 @@ sub checkauth { > -secure => ( C4::Context->https_enabled() ? 1 : 0 ), > -sameSite => 'Lax', > )); >- $loggedin = 1; > } > elsif ( $emailaddress) { > # the Google OpenID Connect passes an email address >@@ -1200,7 +1198,6 @@ sub checkauth { > my $domain = $branches->{$branchcode}->{'branchip'}; > $domain =~ s|\.\*||g; > if ( $ip !~ /^$domain/ ) { >- $loggedin = 0; > $cookie = $cookie_mgr->replace_in_list( $cookie, $query->cookie( > -name => 'CGISESSID', > -value => '', >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35904
:
161377
|
161378
|
162134
|
162135
|
162151
|
162168
|
162169
|
162187
|
162188
|
162217