Bugzilla – Attachment 161504 Details for
Bug 35422
Unexpected translation string for Suggestions template
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35422: Fix translation of suggestions title tag
Bug-35422-Fix-translation-of-suggestions-title-tag.patch (text/plain), 1.79 KB, created by
Marcel de Rooy
on 2024-01-26 10:49:25 UTC
(
hide
)
Description:
Bug 35422: Fix translation of suggestions title tag
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2024-01-26 10:49:25 UTC
Size:
1.79 KB
patch
obsolete
>From 7d75a21e9c4bb2da66786a06e1624d9c60d323d2 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 28 Nov 2023 15:54:38 +0000 >Subject: [PATCH] Bug 35422: Fix translation of suggestions title tag >Content-Type: text/plain; charset=utf-8 > >This patch corrects a missed instance of a string in the title tag which >should have been wrapped in the translation function [% t() %] > >To test, apply the patch and go to Suggestions. > >- Click "New purchase suggestion" >- The title of the page should be correct: "Add suggestion" >- Confirm that translation is improved: > - Update and reinstall active translations (for instance fr-FR): > perl misc/translator/translate update fr-FR > - Check the corresponding po file, in this case fr-FR-messages.po > - There should be an entry for the string "Add suggestion" > >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > .../intranet-tmpl/prog/en/modules/suggestion/suggestion.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >index 657a2a5cbd..85ef39ade7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >@@ -13,7 +13,7 @@ > [% IF ( suggestionid ) %] > [% tx("Edit suggestion #{suggestion_number}", { suggestion_number = suggestionid }) | html %] › > [% ELSE %] >- Add suggestion › >+ [% t("Add suggestion") | html %] › > [% END %] > [% ELSIF ( op == 'show' ) %] > [% tx("Show suggestion #{suggestion_number}", { suggestion_number = suggestionid }) | html %] › >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35422
:
159304
|
159326
| 161504