Bugzilla – Attachment 161558 Details for
Bug 23208
Ability to set default ratio in holds ratio report
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23208: Add ability to set a default hold ratio value
Bug-23208-Add-ability-to-set-a-default-hold-ratio-.patch (text/plain), 2.43 KB, created by
Lucas Gass (lukeg)
on 2024-01-26 18:48:34 UTC
(
hide
)
Description:
Bug 23208: Add ability to set a default hold ratio value
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2024-01-26 18:48:34 UTC
Size:
2.43 KB
patch
obsolete
>From f06a29d152b40aa1993433cbe084dd63bd91a285 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Fri, 26 Jan 2024 18:43:06 +0000 >Subject: [PATCH] Bug 23208: Add ability to set a default hold ratio value > >To test: >1. APPLY PATCH, updatedatebase, restart_all >2. Search for the system preference 'HoldRatioDefault'. >3. It should be set to 3. Change the value to something else. >4. Load the report at 'circ/reserveratios.pl'. Circulation > Hold ratios >5. The default value should be the value you set in the new system preference. >6. Run the report with the default value and make sure it works. >7. Change the value and run the report. The new value should be retained. >8. Leave the page and come back. Again the default value from the new system preference should be set. >--- > circ/reserveratios.pl | 2 +- > .../prog/en/modules/admin/preferences/circulation.pref | 5 +++++ > 2 files changed, 6 insertions(+), 1 deletion(-) > >diff --git a/circ/reserveratios.pl b/circ/reserveratios.pl >index 3152855639..23b664463d 100755 >--- a/circ/reserveratios.pl >+++ b/circ/reserveratios.pl >@@ -69,7 +69,7 @@ $enddate = $todaysdate unless $enddate; > $startdate = $todaysdate->clone->subtract( years => 1 ) unless $startdate; > > if (!defined($ratio)) { >- $ratio = 3; >+ $ratio = C4::Context->preference('HoldRatioDefault'); > } > # Force to be a number > $ratio += 0; >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >index 0ce5e1919e..4fe9a9d763 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >@@ -689,6 +689,11 @@ Circulation: > 0: "Don't store" > - 'the last patron to return an item. This setting is independent of the <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=opacreadinghistory">opacreadinghistory</a> and <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=AnonymousPatron">AnonymousPatron</a> system preferences.' > Holds policy: >+ - >+ - Default the holds ratio report to >+ - pref: HoldRatioDefault >+ class: integer >+ - "." > - > - In the staff interface, split the holds queue into separate tables by > - pref: HoldsSplitQueue >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23208
:
161557
|
161558
|
161559
|
161729
|
161730
|
161731
|
161855
|
161856
|
161857