Attachment 161626 Details for Bug 35936 – Bug 35936: Fix saving existing report with incorrect AV category

[patch] Bug 35936: Fix saving existing report with incorrect AV category

Bug-35936-Fix-saving-existing-report-with-incorrec.patch (text/plain), 1.91 KB, created by Jonathan Druart on 2024-01-30 09:06:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2024-01-30 09:06:17 UTC

Size: 1.91 KB

patch

obsolete

>From bee66af70c5f3e965c8cb7d231a6c487f543bcd5 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 30 Jan 2024 10:04:45 +0100
>Subject: [PATCH] Bug 35936: Fix saving existing report with incorrect AV
> category
>
>When an existing report is saved and an incorrect AV category is selected,
>the UI is asking "do you want to save anyway", but the "Update SQL" button
>leads to a blank page and the report is not saved.
>
>On bug 33966 the value is been adjust to 'update_sql' but this incorrect
>was left.
>
>To test you need to use the browser inspector to adjust the value of the
>selected option.
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> .../prog/en/modules/reports/guided_reports_start.tt             | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>index 5d1132bb426..874d91e29a0 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>@@ -826,7 +826,7 @@
>                             <input type='hidden' name='cache_expiry_units' value='[% cache_expiry_units | html %]' />
>                             <input type='hidden' name='public' value='[% public | html %]' />
>                         [% IF ( phase_update) %]
>-                            <input type='hidden' name='phase' value='Update SQL' />
>+                            <input type='hidden' name='phase' value='update_sql' />
>                             <button type="submit" name="save_anyway" value="Save anyway" class="approve"><i class="fa fa-fw fa-check"></i> Save anyway</button>
>                         [% ELSIF ( phase_save) %]
>                             <input type='hidden' name='area' value='[% area | html %]' />
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 35936: 161626