Bugzilla – Attachment 16163 Details for
Bug 7596
System preferences editor JavaScript contains untranslatable English string
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7596 - System prefs editor JS contains untranslatable English string
Bug-7596---System-prefs-editor-JS-contains-untrans.patch (text/plain), 2.42 KB, created by
Jonathan Druart
on 2013-03-15 12:55:57 UTC
(
hide
)
Description:
Bug 7596 - System prefs editor JS contains untranslatable English string
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2013-03-15 12:55:57 UTC
Size:
2.42 KB
patch
obsolete
>From e9c8a4f95d465ad0866768f5a2f1c7b44c49818d Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Mon, 11 Mar 2013 20:53:55 -0400 >Subject: [PATCH] Bug 7596 - System prefs editor JS contains untranslatable > English string > >There is one stray instance of an untranslatable string in >preferences.js. This patch replaces it with a variable which is now >defined in the preferences template. > >To test, open the system preferences editor and change any setting. You >should see the usual "Saved preference <preference name>" message. > >To test that error strings are now translatable, run "perl translate >update <lang>" from misc/translator, then check if the affected strings shows >up in the po file. > >Signed-off-by: Liz Rea <liz@catalyst.net.nz> >Tested both, all ok. > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >--- > koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js b/koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js >index 96e9e99..8fe6369 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js >+++ b/koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js >@@ -21,7 +21,7 @@ KOHA.Preferences = { > modified_prefs.each(function(){ > var modified_pref = $(this).attr("id"); > modified_pref = modified_pref.replace("pref_",""); >- msg += '<strong>Saved preference '+modified_pref+'</strong>\n'; >+ msg += "<strong>"+ MSG_SAVED_PREFERENCE + " " + modified_pref + "</strong>\n"; > }); > humanMsg.displayAlert(msg); > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt >index ebb9d8c..04ebe76 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt >@@ -17,6 +17,7 @@ > var search_jumped = [% IF ( search_jumped ) %]true[% ELSE %]false[% END %]; > var MSG_NOTHING_TO_SAVE = _("Nothing to save"); > var MSG_SAVING = _("Saving..."); >+ var MSG_SAVED_PREFERENCE = _("Saved preference"); > var MSG_MODIFIED = _("modified"); > var MSG_MADE_CHANGES = _("You have made changes to system preferences."); > var MSG_CLICK_TO_EXPAND = _("Click to expand this section"); >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7596
:
16056
|
16106
| 16163