Attachment 161659 Details for Bug 35248 – Bug 35248: Add Koha::Biblio->bookings unit test

[patch] Bug 35248: Add Koha::Biblio->bookings unit test

Bug-35248-Add-KohaBiblio-bookings-unit-test.patch (text/plain), 1.76 KB, created by Martin Renvoize (ashimema) on 2024-01-30 17:10:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-01-30 17:10:05 UTC

Size: 1.76 KB

patch

obsolete

>From cc57824a4eef64dfcbc65baf10634a1f53448c37 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Tue, 30 Jan 2024 14:00:17 +0000
>Subject: [PATCH] Bug 35248: Add Koha::Biblio->bookings unit test
>
>This patch adds unit tests for the bookings relationship accessor on
>Koha::Biblio objects.
>
>Test plan
>1) Run t/db_dependant/Koha/Biblio.t
>---
> t/db_dependent/Koha/Biblio.t | 36 +++++++++++++++++++++++++++++++++++-
> 1 file changed, 35 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Koha/Biblio.t b/t/db_dependent/Koha/Biblio.t
>index 13be09f4662..5624ac28c14 100755
>--- a/t/db_dependent/Koha/Biblio.t
>+++ b/t/db_dependent/Koha/Biblio.t
>@@ -17,7 +17,7 @@
> 
> use Modern::Perl;
> 
>-use Test::More tests => 30;
>+use Test::More tests => 31;
> use Test::Exception;
> use Test::Warn;
> 
>@@ -486,6 +486,40 @@ subtest 'to_api() tests' => sub {
>     $schema->storage->txn_rollback;
> };
> 
>+subtest 'bookings() tests' => sub {
>+
>+    plan tests => 3;
>+
>+    $schema->storage->txn_begin;
>+
>+    my $biblio = $builder->build_sample_biblio();
>+
>+    is( ref( $biblio->bookings ), 'Koha::Bookings', 'Return type is correct' );
>+
>+    is_deeply(
>+        $biblio->bookings->unblessed,
>+        [],
>+        '->bookings returns an empty Koha::Bookings resultset'
>+    );
>+
>+    my $booking = $builder->build_object(
>+        {
>+            class => 'Koha::Bookings',
>+            value => { biblio_id => $biblio->biblionumber }
>+        }
>+    );
>+
>+    my $bookings = $biblio->bookings->unblessed;
>+
>+    is_deeply(
>+        $biblio->bookings->unblessed,
>+        [ $booking->unblessed ],
>+        '->bookings returns the related Koha::Booking objects'
>+    );
>+
>+    $schema->storage->txn_rollback;
>+};
>+
> subtest 'suggestions() tests' => sub {
> 
>     plan tests => 3;
>-- 
>2.43.0

Actions: View | Diff | Splinter Review

Attachments on bug 35248: 161061 | 161062 | 161608 | 161611 | 161620 | 161621 | 161632 | 161636 | 161651 | 161652 | 161653 | 161654 | 161655 | 161656 | 161657 | 161658 | 161659 | 161660 | 161821 | 161822 | 161823 | 161824 | 161825 | 161826 | 161827 | 161828 | 161829 | 161830 | 161831 | 161861 | 161862 | 161863 | 161864 | 161865 | 161866 | 161867 | 161868 | 161869 | 161870 | 161871 | 161890 | 161891 | 161893 | 161894 | 161895 | 161896 | 161897 | 161898 | 161899 | 161900 | 161901 | 161902 | 161903 | 161904 | 161905 | 161906 | 161907 | 161908 | 161909 | 161910 | 161911 | 161912