Bugzilla – Attachment 161711 Details for
Bug 23978
Notes field in saved reports should allow for HTML
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23978: Expose HTML in Reports
Bug-23978-Expose-HTML-in-Reports.patch (text/plain), 4.62 KB, created by
Martin Renvoize (ashimema)
on 2024-02-01 06:46:29 UTC
(
hide
)
Description:
Bug 23978: Expose HTML in Reports
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2024-02-01 06:46:29 UTC
Size:
4.62 KB
patch
obsolete
>From 53755454657ed9cbef1f947241d4f28ce64db93b Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Tue, 21 Sep 2021 10:27:15 +0200 >Subject: [PATCH] Bug 23978: Expose HTML in Reports > >This patch updates the notes field to a $raw filter to prevent html >escaping of the data within it. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > .../en/modules/reports/guided_reports_start.tt | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >index 1b639d26c66..5083b83c60e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >@@ -822,7 +822,7 @@ > <input type='hidden' name='reportname' value='[% reportname | html %]' /> > <input type='hidden' name='group' value='[% group | html %]' /> > <input type='hidden' name='subgroup' value='[% subgroup | html %]' /> >- <input type='hidden' name='notes' value='[% notes | html %]' /> >+ <input type='hidden' name='notes' value='[% notes | $raw %]' /> > <input type='hidden' name='cache_expiry' value='[% cache_expiry | html %]' /> > <input type='hidden' name='cache_expiry_units' value='[% cache_expiry_units | html %]' /> > <input type='hidden' name='public' value='[% public | html %]' /> >@@ -861,7 +861,7 @@ > <input type='hidden' name='phase' value='Run this report' /> > <h1>Enter parameters for report [% name | html %]:</h1> > [% IF ( notes ) %] >- <p>[% notes | html %]</p> >+ <p>[% notes | $raw %]</p> > [% END %] > <fieldset class="rows"> > <ol> >@@ -910,7 +910,7 @@ > <h1>[% name | html %] <span class="report_heading_id"><span class="report_label">Report ID:</span> <span class="report_number">[% id | html %]</span></span></h1> > <div class="page-section"> > [% IF ( notes ) %] >- <p><span class="label">Notes:</span> [% notes | html %]</p> >+ <p><span class="label">Notes:</span> [% notes | $raw %]</p> > [% END %] > [% IF ( unlimited_total ) %] > <p> >@@ -1276,7 +1276,7 @@ > [% END # /IF (usecache) %] > <li> > <label for="notes">Notes:</label> >- <textarea id="notes" name="notes" cols="50" rows="2">[% notes | html %]</textarea> >+ <textarea id="notes" name="notes" cols="50" rows="2">[% notes | $raw %]</textarea> > </li> > </ol> > </fieldset> <!-- /.rows --> >@@ -1304,7 +1304,7 @@ > [% IF saved_results %] > <h1>Saved report results</h1> > <h2>[% name | html %]</h2> >- <p>[% notes | html %]</p> >+ <p>[% notes | $raw %]</p> > <table> > [% FOREACH rows IN saved_results %] > <tr> >@@ -1324,7 +1324,7 @@ > [% IF ( notes ) %] > <li> > <span class="label">Notes:</span> >- [% notes | html %] >+ [% notes | $raw %] > </li> > [% ELSE %] > [% END %] >@@ -1390,7 +1390,7 @@ > [% END %] > <li> > <label for="notes">Notes:</label> >- <textarea id="notes" name="notes" cols="50" rows="2">[% notes | html %]</textarea> >+ <textarea id="notes" name="notes" cols="50" rows="2">[% notes | $raw %]</textarea> > </li> > </ol> > </fieldset> <!-- /.rows --> >@@ -2509,3 +2509,4 @@ > </ul> > </div> > [% END %] >+ >-- >2.43.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23978
:
95107
|
95108
| 161711