Attachment 161728 Details for Bug 35653 – Bug 35653: (QA follow-up) Perltidy

[patch] Bug 35653: (QA follow-up) Perltidy

Bug-35653-QA-follow-up-Perltidy.patch (text/plain), 2.23 KB, created by Emily Lamancusa (emlam) on 2024-02-02 20:24:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Emily Lamancusa (emlam)

Created: 2024-02-02 20:24:52 UTC

Size: 2.23 KB

patch

obsolete

>From 3e156c62750f3e095c399416b75a728d4cd197ee Mon Sep 17 00:00:00 2001
>From: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
>Date: Fri, 2 Feb 2024 15:22:14 -0500
>Subject: [PATCH] Bug 35653: (QA follow-up) Perltidy
>
>Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
>---
> misc/import_patrons.pl | 28 +++++++++++++++++++---------
> 1 file changed, 19 insertions(+), 9 deletions(-)
>
>diff --git a/misc/import_patrons.pl b/misc/import_patrons.pl
>index 9428177414..a4affb801c 100755
>--- a/misc/import_patrons.pl
>+++ b/misc/import_patrons.pl
>@@ -41,8 +41,7 @@ my @preserve_fields;
> my $update_dateexpiry;
> my $update_dateexpiry_from_today;
> 
>-
>-my $command_line_options = join(" ",@ARGV);
>+my $command_line_options = join( " ", @ARGV );
> 
> GetOptions(
>     'c|confirm'                      => \$confirm,
>@@ -64,8 +63,8 @@ pod2usage(1) if $help;
> pod2usage(q|--file is required|) unless $csv_file;
> pod2usage(q|--matchpoint is required|) unless $matchpoint;
> 
>-if ( $confirm ) {
>-    cronlogaction({ action => 'Run', info => $command_line_options })
>+if ($confirm) {
>+    cronlogaction( { action => 'Run', info => $command_line_options } );
> } else {
>     warn "Running in dry-run mode, provide --confirm to apply the changes\n";
> }
>@@ -95,7 +94,7 @@ my $imported    = $return->{imported};
> my $overwritten = $return->{overwritten};
> my $alreadyindb = $return->{already_in_db};
> my $invalid     = $return->{invalid};
>-my $total = $imported + $alreadyindb + $invalid + $overwritten;
>+my $total       = $imported + $alreadyindb + $invalid + $overwritten;
> 
> if ($verbose) {
>     say q{};
>@@ -118,10 +117,21 @@ if ($verbose > 2 ) {
>     say Data::Dumper::Dumper( $feedback );
> }
> 
>-my $info = "Import complete. " . "Imported: " . $imported . " Overwritten: " . $overwritten . " Skipped: " . $alreadyindb . " Invalid: " . $invalid . " Total: " . $total;
>-
>-if ( $confirm ) {
>-    cronlogaction({ action => 'End', info => $info });
>+my $info =
>+      "Import complete. "
>+    . "Imported: "
>+    . $imported
>+    . " Overwritten: "
>+    . $overwritten
>+    . " Skipped: "
>+    . $alreadyindb
>+    . " Invalid: "
>+    . $invalid
>+    . " Total: "
>+    . $total;
>+
>+if ($confirm) {
>+    cronlogaction( { action => 'End', info => $info } );
> }
> 
> =head1 NAME
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 35653: 160325 | 160384 | 161727 | 161728