Bugzilla – Attachment 161757 Details for
Bug 35819
"No job found" error for BatchUpdateBiblioHoldsQueue (race condition)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35819: (QA follow-up) Prevent warning on uninitialized retries count
Bug-35819-QA-follow-up-Prevent-warning-on-uninitia.patch (text/plain), 1.77 KB, created by
Marcel de Rooy
on 2024-02-05 11:27:09 UTC
(
hide
)
Description:
Bug 35819: (QA follow-up) Prevent warning on uninitialized retries count
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2024-02-05 11:27:09 UTC
Size:
1.77 KB
patch
obsolete
>From 34b264a3d7ee65b9a6ba198b3e45b8caedfe5327 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Mon, 5 Feb 2024 11:13:15 +0000 >Subject: [PATCH] Bug 35819: (QA follow-up) Prevent warning on uninitialized > retries count >Content-Type: text/plain; charset=utf-8 > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > misc/workers/background_jobs_worker.pl | 3 ++- > misc/workers/es_indexer_daemon.pl | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) > >diff --git a/misc/workers/background_jobs_worker.pl b/misc/workers/background_jobs_worker.pl >index 94c458268c..e34ec54f25 100755 >--- a/misc/workers/background_jobs_worker.pl >+++ b/misc/workers/background_jobs_worker.pl >@@ -145,7 +145,8 @@ while (1) { > } > > unless ($job) { >- if ( ++$not_found_retries->{$args->{job_id}} >= $max_retries ) { >+ $not_found_retries->{ $args->{job_id} } //= 0; >+ if ( ++$not_found_retries->{ $args->{job_id} } >= $max_retries ) { > Koha::Logger->get( { interface => 'worker' } ) > ->warn( sprintf "Job %s not found, no more retry", $args->{job_id} ); > >diff --git a/misc/workers/es_indexer_daemon.pl b/misc/workers/es_indexer_daemon.pl >index 5f34345391..9e900b7195 100755 >--- a/misc/workers/es_indexer_daemon.pl >+++ b/misc/workers/es_indexer_daemon.pl >@@ -143,7 +143,8 @@ while (1) { > } > > unless ($job) { >- if ( ++$not_found_retries->{$args->{job_id}} >= $max_retries ) { >+ $not_found_retries->{ $args->{job_id} } //= 0; >+ if ( ++$not_found_retries->{ $args->{job_id} } >= $max_retries ) { > Koha::Logger->get( { interface => 'worker' } ) > ->warn( sprintf "Job %s not found, no more retry", $args->{job_id} ); > >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35819
:
161067
|
161071
|
161139
|
161172
|
161173
|
161267
|
161527
|
161624
|
161682
|
161683
|
161684
|
161685
|
161686
|
161752
|
161753
|
161754
|
161755
|
161756
| 161757