Bugzilla – Attachment 161826 Details for
Bug 35248
Bookings needs unit tests
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35248: Add test for Koha::Exceptions::Booking
Bug-35248-Add-test-for-KohaExceptionsBooking.patch (text/plain), 1.36 KB, created by
Martin Renvoize (ashimema)
on 2024-02-07 16:41:08 UTC
(
hide
)
Description:
Bug 35248: Add test for Koha::Exceptions::Booking
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2024-02-07 16:41:08 UTC
Size:
1.36 KB
patch
obsolete
>From 4c1bd97f25180850e6fbb8b0c505700d09e4baa1 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Tue, 30 Jan 2024 07:45:13 +0000 >Subject: [PATCH] Bug 35248: Add test for Koha::Exceptions::Booking > >--- > t/Koha/Exceptions.t | 17 ++++++++++++++++- > 1 file changed, 16 insertions(+), 1 deletion(-) > >diff --git a/t/Koha/Exceptions.t b/t/Koha/Exceptions.t >index 748a0f8084a..9a6ce3ab37f 100755 >--- a/t/Koha/Exceptions.t >+++ b/t/Koha/Exceptions.t >@@ -17,7 +17,7 @@ > > use Modern::Perl; > >-use Test::More tests => 11; >+use Test::More tests => 12; > use Test::MockObject; > use Test::Exception; > >@@ -337,6 +337,21 @@ subtest 'Koha::Exceptions::Plugin tests' => sub { > is( "$@", "Calling 'upgrade' died for plugin $plugin_class", 'Exception stringified correctly' ); > }; > >+subtest 'Koha::Exceptions::Booking tests' => sub { >+ >+ plan tests => 3; >+ >+ use_ok('Koha::Exceptions::Booking'); >+ >+ throws_ok { Koha::Exceptions::Booking::Clash->throw() } >+ 'Koha::Exceptions::Booking::Clash', >+ 'Exception is thrown :-D'; >+ >+ # stringify the exception >+ is( "$@", '[Adding or updating the booking would result in a clash]', 'Exception stringified correctly' ); >+ # FIXME: I don't understand why the stringified message here gets wrapped in square brackets... >+}; >+ > subtest 'Koha::Exception tests' => sub { > > plan tests => 8; >-- >2.43.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35248
:
161061
|
161062
|
161608
|
161611
|
161620
|
161621
|
161632
|
161636
|
161651
|
161652
|
161653
|
161654
|
161655
|
161656
|
161657
|
161658
|
161659
|
161660
|
161821
|
161822
|
161823
|
161824
|
161825
|
161826
|
161827
|
161828
|
161829
|
161830
|
161831
|
161861
|
161862
|
161863
|
161864
|
161865
|
161866
|
161867
|
161868
|
161869
|
161870
|
161871
|
161890
|
161891
|
161893
|
161894
|
161895
|
161896
|
161897
|
161898
|
161899
|
161900
|
161901
|
161902
|
161903
|
161904
|
161905
|
161906
|
161907
|
161908
|
161909
|
161910
|
161911
|
161912