Attachment 161831 Details for Bug 35248 – Bug 35248: Add unit tests for Koha::Bibilio->bookable_items

[patch] Bug 35248: Add unit tests for Koha::Bibilio->bookable_items

Bug-35248-Add-unit-tests-for-KohaBibilio-bookablei.patch (text/plain), 1.87 KB, created by Martin Renvoize (ashimema) on 2024-02-07 16:41:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-02-07 16:41:20 UTC

Size: 1.87 KB

patch

obsolete

>From f93848bf3d38c5237e0bfdda2bdfab7bc2c0c8e3 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Wed, 7 Feb 2024 16:38:20 +0000
>Subject: [PATCH] Bug 35248: Add unit tests for Koha::Bibilio->bookable_items
>
>This patch adds basic unit tests for Koha::Biblio->bookable_items
>
>Test plan
>1) Run t/db_dependent/Koha/Biblio.t
>---
> t/db_dependent/Koha/Biblio.t | 26 +++++++++++++++++++++++++-
> 1 file changed, 25 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Koha/Biblio.t b/t/db_dependent/Koha/Biblio.t
>index b17e02c137b..017aeecc9f4 100755
>--- a/t/db_dependent/Koha/Biblio.t
>+++ b/t/db_dependent/Koha/Biblio.t
>@@ -17,7 +17,7 @@
> 
> use Modern::Perl;
> 
>-use Test::More tests => 32;
>+use Test::More tests => 33;
> use Test::Exception;
> use Test::Warn;
> 
>@@ -148,6 +148,30 @@ subtest 'items() tests' => sub {
> 
> };
> 
>+subtest 'bookable_items() tests' => sub {
>+    plan tests => 3;
>+
>+    $schema->storage->txn_begin;
>+
>+    my $biblio = $builder->build_sample_biblio();
>+
>+    # bookable items
>+    my $bookable_item1 = $builder->build_sample_item( { biblionumber => $biblio->biblionumber, bookable => 1 } );
>+
>+    # not bookable items
>+    my $non_bookable_item1 = $builder->build_sample_item( { biblionumber => $biblio->biblionumber, bookable => 0 } );
>+    my $non_bookable_item2 = $builder->build_sample_item( { biblionumber => $biblio->biblionumber, bookable => 0 } );
>+
>+    is( ref( $biblio->bookable_items ), 'Koha::Items', "bookable_items returns a Koha::Items resultset" );
>+    is( $biblio->bookable_items->count, 1,             "bookable_items returns the correct number of items" );
>+    is(
>+        $biblio->bookable_items->next->itemnumber, $bookable_item1->itemnumber,
>+        "bookable_items returned the correct item"
>+    );
>+
>+    $schema->storage->txn_rollback;
>+};
>+
> subtest 'get_coins and get_openurl' => sub {
> 
>     plan tests => 4;
>-- 
>2.43.0

Actions: View | Diff | Splinter Review

Attachments on bug 35248: 161061 | 161062 | 161608 | 161611 | 161620 | 161621 | 161632 | 161636 | 161651 | 161652 | 161653 | 161654 | 161655 | 161656 | 161657 | 161658 | 161659 | 161660 | 161821 | 161822 | 161823 | 161824 | 161825 | 161826 | 161827 | 161828 | 161829 | 161830 | 161831 | 161861 | 161862 | 161863 | 161864 | 161865 | 161866 | 161867 | 161868 | 161869 | 161870 | 161871 | 161890 | 161891 | 161893 | 161894 | 161895 | 161896 | 161897 | 161898 | 161899 | 161900 | 161901 | 161902 | 161903 | 161904 | 161905 | 161906 | 161907 | 161908 | 161909 | 161910 | 161911 | 161912