Attachment 161866 Details for Bug 35248 – Bug 35248: Add test for Koha::Exceptions::Booking

[patch] Bug 35248: Add test for Koha::Exceptions::Booking

Bug-35248-Add-test-for-KohaExceptionsBooking.patch (text/plain), 1.40 KB, created by David Nind on 2024-02-07 22:52:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2024-02-07 22:52:46 UTC

Size: 1.40 KB

patch

obsolete

>From 6c035f2fb19e176852e605201ab59cc1c36d0d26 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Tue, 30 Jan 2024 07:45:13 +0000
>Subject: [PATCH] Bug 35248: Add test for Koha::Exceptions::Booking
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> t/Koha/Exceptions.t | 17 ++++++++++++++++-
> 1 file changed, 16 insertions(+), 1 deletion(-)
>
>diff --git a/t/Koha/Exceptions.t b/t/Koha/Exceptions.t
>index 748a0f8084..9a6ce3ab37 100755
>--- a/t/Koha/Exceptions.t
>+++ b/t/Koha/Exceptions.t
>@@ -17,7 +17,7 @@
> 
> use Modern::Perl;
> 
>-use Test::More tests => 11;
>+use Test::More tests => 12;
> use Test::MockObject;
> use Test::Exception;
> 
>@@ -337,6 +337,21 @@ subtest 'Koha::Exceptions::Plugin tests' => sub {
>     is( "$@", "Calling 'upgrade' died for plugin $plugin_class", 'Exception stringified correctly' );
> };
> 
>+subtest 'Koha::Exceptions::Booking tests' => sub {
>+
>+    plan tests => 3;
>+
>+    use_ok('Koha::Exceptions::Booking');
>+
>+    throws_ok { Koha::Exceptions::Booking::Clash->throw() }
>+    'Koha::Exceptions::Booking::Clash',
>+        'Exception is thrown :-D';
>+
>+    # stringify the exception
>+    is( "$@", '[Adding or updating the booking would result in a clash]', 'Exception stringified correctly' );
>+    # FIXME: I don't understand why the stringified message here gets wrapped in square brackets...
>+};
>+
> subtest 'Koha::Exception tests' => sub {
> 
>     plan tests => 8;
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 35248: 161061 | 161062 | 161608 | 161611 | 161620 | 161621 | 161632 | 161636 | 161651 | 161652 | 161653 | 161654 | 161655 | 161656 | 161657 | 161658 | 161659 | 161660 | 161821 | 161822 | 161823 | 161824 | 161825 | 161826 | 161827 | 161828 | 161829 | 161830 | 161831 | 161861 | 161862 | 161863 | 161864 | 161865 | 161866 | 161867 | 161868 | 161869 | 161870 | 161871 | 161890 | 161891 | 161893 | 161894 | 161895 | 161896 | 161897 | 161898 | 161899 | 161900 | 161901 | 161902 | 161903 | 161904 | 161905 | 161906 | 161907 | 161908 | 161909 | 161910 | 161911 | 161912