Bugzilla – Attachment 162019 Details for
Bug 35930
ILL module broken if plugins disabled
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35930: Add guards for plugins_enabled
Bug-35930-Add-guards-for-pluginsenabled.patch (text/plain), 2.18 KB, created by
Pedro Amorim
on 2024-02-12 12:20:27 UTC
(
hide
)
Description:
Bug 35930: Add guards for plugins_enabled
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2024-02-12 12:20:27 UTC
Size:
2.18 KB
patch
obsolete
>From 3140940111bea18916e26f60ed434c1afe115d3f Mon Sep 17 00:00:00 2001 >From: Andreas Jonsson <andreas.jonsson@kreablo.se> >Date: Mon, 12 Feb 2024 11:16:02 +0000 >Subject: [PATCH] Bug 35930: Add guards for plugins_enabled > >The 'new' method in Koha::Plugins returns undefined if >plugins are disabled. Therefore, calls to this method >must be guarded by a check that plugins actually are enabled. > >Test plan: > >* Code inspection of patch, alternatively >* Activate the ill system by installing a backend such as > koha-illbackend-libris: > https://github.com/Libriotech/koha-illbackend-libris >* Make sure plugins are disabled in koha-conf.xml >* In the staff interface, go to ILL requests. >* The page should load without getting an error 500. > >PA amended commit message: This is not related to ILL backends being plugins or not >This is about ILL batches, where checking for metadata enrichment plugins was missing 'enable_plugins' guard >Additionally, unrelated to batches, it's also about ILLAvailability, where checking for ILL availabililty plugins was missing enable_plugins guard > >Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> >--- > Koha/Illrequest/Workflow/Availability.pm | 2 ++ > ill/ill-requests.pl | 1 + > 2 files changed, 3 insertions(+) > >diff --git a/Koha/Illrequest/Workflow/Availability.pm b/Koha/Illrequest/Workflow/Availability.pm >index 4fd75a48a95..bcc50f6fe70 100644 >--- a/Koha/Illrequest/Workflow/Availability.pm >+++ b/Koha/Illrequest/Workflow/Availability.pm >@@ -64,6 +64,8 @@ sub get_services { > $plugin_filter->{metadata} = $params->{metadata}; > } > >+ return [] unless C4::Context->config("enable_plugins"); >+ > my @candidates = Koha::Plugins->new()->GetPlugins($plugin_filter); > my @services = (); > foreach my $plugin (@candidates) { >diff --git a/ill/ill-requests.pl b/ill/ill-requests.pl >index 9912bc7f167..2a1ed678485 100755 >--- a/ill/ill-requests.pl >+++ b/ill/ill-requests.pl >@@ -531,6 +531,7 @@ sub can_batch { > > # Get available metadata enrichment plugins > sub get_metadata_enrichment { >+ return [] unless C4::Context->config("enable_plugins"); > my @candidates = Koha::Plugins->new()->GetPlugins({ > method => 'provides_api' > }); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35930
:
162018
|
162019
|
162038