Bugzilla – Attachment 16202 Details for
Bug 7241
circulation action logs record biblionumber instead of item number
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7241: circulation action logs record biblionumber instead of item number
Bug-7241-circulation-action-logs-record-biblionumb.patch (text/plain), 3.58 KB, created by
Marcel de Rooy
on 2013-03-17 16:31:48 UTC
(
hide
)
Description:
Bug 7241: circulation action logs record biblionumber instead of item number
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2013-03-17 16:31:48 UTC
Size:
3.58 KB
patch
obsolete
>From a85b1b51b2d2e72c578ad07c510e181773ab3787 Mon Sep 17 00:00:00 2001 >From: Adrien Saurat <adrien.saurat@biblibre.com> >Date: Tue, 22 Jan 2013 14:46:38 +0100 >Subject: [PATCH] Bug 7241: circulation action logs record biblionumber > instead of item number >Content-Type: text/plain; charset="utf-8" > >Issue log and and circulation logs are incorrectly recording biblionumber instead of item number, creating incorrect logs. >This patch corrects this, and modifies the action_logs table in two ways: >- the timestamp is not updated anymore with UPDATES (but still automatically filled when INSERTing) >- to partially correct the broken logs, the log history is filled with the first found item for each biblio > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > C4/Circulation.pm | 4 ++-- > installer/data/mysql/kohastructure.sql | 2 +- > installer/data/mysql/updatedatabase.pl | 8 ++++++++ > 3 files changed, 11 insertions(+), 3 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index abd4981..e7fe5b9 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -1307,7 +1307,7 @@ sub AddIssue { > } > } > >- logaction("CIRCULATION", "ISSUE", $borrower->{'borrowernumber'}, $biblio->{'biblionumber'}) >+ logaction("CIRCULATION", "ISSUE", $borrower->{'borrowernumber'}, $biblio->{'itemnumber'}) > if C4::Context->preference("IssueLog"); > } > return ($datedue); # not necessarily the same as when it came in! >@@ -1875,7 +1875,7 @@ sub AddReturn { > }); > } > >- logaction("CIRCULATION", "RETURN", $borrowernumber, $item->{'biblionumber'}) >+ logaction("CIRCULATION", "RETURN", $borrowernumber, $item->{'itemnumber'}) > if C4::Context->preference("ReturnLog"); > > # FIXME: make this comment intelligible. >diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql >index 221c4e4..d3a4f1d 100644 >--- a/installer/data/mysql/kohastructure.sql >+++ b/installer/data/mysql/kohastructure.sql >@@ -2538,7 +2538,7 @@ CREATE TABLE `accountoffsets` ( > DROP TABLE IF EXISTS `action_logs`; > CREATE TABLE `action_logs` ( -- logs of actions taken in Koha (requires that the logs be turned on) > `action_id` int(11) NOT NULL auto_increment, -- unique identifier for each action >- `timestamp` timestamp NOT NULL default CURRENT_TIMESTAMP on update CURRENT_TIMESTAMP, -- the date and time the action took place >+ `timestamp` timestamp NOT NULL default CURRENT_TIMESTAMP, -- the date and time the action took place > `user` int(11) NOT NULL default 0, -- the staff member who performed the action (borrowers.borrowernumber) > `module` text, -- the module this action was taken against > `action` text, -- the action (includes things like DELETED, ADDED, MODIFY, etc) >diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl >index cca1b12..e5c133d 100755 >--- a/installer/data/mysql/updatedatabase.pl >+++ b/installer/data/mysql/updatedatabase.pl >@@ -6526,6 +6526,14 @@ if ( CheckVersion($DBversion) ) { > SetVersion($DBversion); > } > >+$DBversion = "3.11.00.XXX"; >+if ( CheckVersion($DBversion) ) { >+ $dbh->do("ALTER TABLE action_logs CHANGE timestamp timestamp TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP;"); >+ $dbh->do("UPDATE action_logs SET info=(SELECT itemnumber FROM items WHERE biblionumber= action_logs.info LIMIT 1) WHERE module='CIRCULATION' AND action in ('ISSUE','RETURN');"); >+ print "Upgrade to $DBversion done (Bug 7241: Changing timestamp autoupdate on action_logs; setting items to circulation logs where missing)\n"; >+ SetVersion($DBversion); >+} >+ > > =head1 FUNCTIONS > >-- >1.7.7.6
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7241
:
7088
|
7471
|
9870
|
11415
|
12043
|
12434
|
14745
|
14945
|
16202
|
16627
|
16636
|
16637
|
16638
|
16661