Bugzilla – Attachment 162115 Details for
Bug 36051
Add option to specify SMS::Send driver parameters in a system preference instead of a file
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36051 (QA follow-up): Use yaml_preference
Bug-36051-QA-follow-up-Use-yamlpreference.patch (text/plain), 1.26 KB, created by
Kyle M Hall (khall)
on 2024-02-13 16:03:05 UTC
(
hide
)
Description:
Bug 36051 (QA follow-up): Use yaml_preference
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2024-02-13 16:03:05 UTC
Size:
1.26 KB
patch
obsolete
>From 00fb24d74b73225182263b1e06761853d6841a64 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 13 Feb 2024 11:02:50 -0500 >Subject: [PATCH] Bug 36051 (QA follow-up): Use yaml_preference > >--- > C4/SMS.pm | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-) > >diff --git a/C4/SMS.pm b/C4/SMS.pm >index e3ecae3c167..37be6b8aac3 100644 >--- a/C4/SMS.pm >+++ b/C4/SMS.pm >@@ -110,15 +110,9 @@ sub send_sms { > > # Extract additional SMS::Send arguments from the syspref > # Merge with any arguments from file with syspref taking precedence >- my $sms_send_config_syspref = C4::Context->preference('SMSSendAdditionalOptions'); >- if ( $sms_send_config_syspref ) { >- require YAML::XS; >- >- $sms_send_config_syspref = "$sms_send_config_syspref\n\n"; >- my $yaml; >- eval { $yaml = YAML::XS::Load(Encode::encode_utf8($yaml)); }; >- my %syspref_args = map { q{_} . $_ => $conf->{$_} } keys %$conf; >- %args = ( %args, %syspref_args ); >+ if ( C4::Context->preference('SMSSendAdditionalOptions') ) { >+ my $sms_send_config_syspref = C4::Context->yaml_preference('SMSSendAdditionalOptions'); >+ %args = ( %args, %$sms_send_config_syspref ) if $sms_send_config_syspref; > } > > eval { >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36051
:
161945
|
162115
|
162116
|
162117
|
162118