Attachment 162127 Details for Bug 23296 – Bug 23296: Set patron branchcode when preparing non-digest version

[patch] Bug 23296: Set patron branchcode when preparing non-digest version

Bug-23296-Set-patron-branchcode-when-preparing-non.patch (text/plain), 1.56 KB, created by Brendan Lawlor on 2024-02-13 18:48:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Brendan Lawlor

Created: 2024-02-13 18:48:24 UTC

Size: 1.56 KB

patch

obsolete

>From fc26a2fffe6340d91ea94e30ea29ebf407c7adf6 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Thu, 25 Jan 2024 21:54:21 +0000
>Subject: [PATCH] Bug 23296: Set patron branchcode when preparing non-digest
> version
>
>To test:
>1. APPLY PATCH
>2. Set up circ rules to allow for auto renewals.
>3. Set AutoRenewalNotices to 'according to message prefs'
>4. Make a branch specific version of the the AUTO_RENEWAL notice.
>5. Find a patron belonging to that branch and set the message prefs to allow for a AUTO_RENEWAL. But no digest option!
>6. Check some things out and make sure they are eligble for auto renewal.
>7. Run the cron.
>8. Make sure the patron gets the branch specific notice.
>9. Delete the branch specific notice.
>10. DO 6-7 again.
>11. Make sure they now get the all library notice.
>
>Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
>---
> misc/cronjobs/automatic_renewals.pl | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/misc/cronjobs/automatic_renewals.pl b/misc/cronjobs/automatic_renewals.pl
>index 8661d4f47b..9d765960c8 100755
>--- a/misc/cronjobs/automatic_renewals.pl
>+++ b/misc/cronjobs/automatic_renewals.pl
>@@ -252,6 +252,7 @@ if ( $send_notices && $confirm ) {
>                 my $letter = C4::Letters::GetPreparedLetter (
>                     module      => 'circulation',
>                     letter_code => 'AUTO_RENEWALS',
>+                    branchcode => $patron->branchcode,
>                     tables      => {
>                         borrowers => $patron->borrowernumber,
>                         issues    => $issue->itemnumber,
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 23296: 161469 | 162127 | 164452