Bugzilla – Attachment 162152 Details for
Bug 35890
AutoLocation system preference + setting the library IP field - can still login and unexpected results
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35890: Remove var loggedin
Bug-35890-Remove-var-loggedin.patch (text/plain), 1.47 KB, created by
Kyle M Hall (khall)
on 2024-02-14 16:17:42 UTC
(
hide
)
Description:
Bug 35890: Remove var loggedin
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2024-02-14 16:17:42 UTC
Size:
1.47 KB
patch
obsolete
>From 841228ee7551ebb80a25d4dfde622c8072280858 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 24 Jan 2024 16:24:51 +0100 >Subject: [PATCH] Bug 35890: Remove var loggedin > >It is never used and add confusion > >Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > C4/Auth.pm | 3 --- > 1 file changed, 3 deletions(-) > >diff --git a/C4/Auth.pm b/C4/Auth.pm >index ee0e81c0573..fa67d615caa 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -815,7 +815,6 @@ sub checkauth { > _version_check( $type, $query ); > > # state variables >- my $loggedin = 0; > my $auth_state = 'failed'; > my %info; > my ( $userid, $cookie, $sessionID, $flags ); >@@ -855,7 +854,6 @@ sub checkauth { > -secure => ( C4::Context->https_enabled() ? 1 : 0 ), > -sameSite => 'Lax', > )); >- $loggedin = 1; > } > elsif ( $emailaddress) { > # the Google OpenID Connect passes an email address >@@ -1203,7 +1201,6 @@ sub checkauth { > my $domain = $branches->{$branchcode}->{'branchip'}; > $domain =~ s|\.\*||g; > if ( $ip !~ /^$domain/ ) { >- $loggedin = 0; > $cookie = $cookie_mgr->replace_in_list( $cookie, $query->cookie( > -name => 'CGISESSID', > -value => '', >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35890
:
161347
|
161348
|
161375
|
161385
|
161386
|
161701
|
161702
|
161703
|
162136
|
162137
| 162152 |
162153
|
162154