Bugzilla – Attachment 162179 Details for
Bug 23415
Notify patron fines when renewing
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23415: (QA follow-up) Spelling and price formatting
Bug-23415-QA-follow-up-Spelling-and-price-formatti.patch (text/plain), 2.89 KB, created by
Martin Renvoize (ashimema)
on 2024-02-15 08:04:20 UTC
(
hide
)
Description:
Bug 23415: (QA follow-up) Spelling and price formatting
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2024-02-15 08:04:20 UTC
Size:
2.89 KB
patch
obsolete
>From 662a2a0be3df9ab8acabb68a3947aec03ed83581 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Thu, 15 Feb 2024 07:50:14 +0000 >Subject: [PATCH] Bug 23415: (QA follow-up) Spelling and price formatting > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt | 4 ++-- > koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >index 33fce501d84..e53c7fb9976 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >@@ -1008,7 +1008,7 @@ > > var amountlimit = "[% Koha.Preference('FineNoRenewals') | html %]"; > var fines = "[% fines | $Price %]"; >- var MSG_CONFRIM_RENEW = _("The patron has a debt of %s\nAre you sure you want to renew checkout(s)?").format(fines); >+ var MSG_CONFIRM_RENEW = _("The patron has a debt of %s\nAre you sure you want to renew checkout(s)?").format(fines); > > // On-site checkout > function toggle_onsite_checkout(){ >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >index d113367d727..fc85f4449c2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >@@ -731,8 +731,8 @@ > table_settings_holds_table = [% TablesSettings.GetTableSettings( 'members', 'moremember', 'holds-table', 'json' ) | $raw %] > > var amountlimit = "[% Koha.Preference('FineNoRenewals') | html %]"; >- var fines = "[% fines | html %]"; >- var MSG_CONFRIM_RENEW = _("The patron has a debt of %s.\n Are you sure you want to renew checkout(s)?").format(fines); >+ var fines = "[% fines | $Price %]"; >+ var MSG_CONFIRM_RENEW = _("The patron has a debt of %s\n Are you sure you want to renew checkout(s)?").format(fines); > > $(document).ready(function() { > $("#info_digests").tooltip(); >diff --git a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >index 33d1d48951c..ffe9547ee96 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >@@ -644,7 +644,7 @@ $(document).ready(function() { > var itemnumber = $(this).val(); > > if(show_confirm && parseFloat(fines) > parseFloat(amountlimit) ) { >- var result = confirm(MSG_CONFRIM_RENEW); >+ var result = confirm(MSG_CONFIRM_RENEW); > if(!result){ > return false; > } >-- >2.43.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23415
:
92039
|
92541
|
98442
|
98634
|
98996
|
98997
|
105893
|
105894
|
108392
|
109871
|
109872
|
109876
|
109880
|
116919
|
116920
|
116921
|
116922
|
118175
|
118176
|
118177
|
118178
|
118183
|
119300
|
119301
|
119302
|
119303
|
121472
|
139670
|
139671
|
139672
|
139673
|
139674
|
146415
|
148198
|
148199
|
148200
|
148201
|
148202
|
152776
|
152777
|
152778
|
152779
|
152780
|
152781
|
154595
|
154596
|
154597
|
154598
|
154599
|
154600
|
158302
|
158303
|
158304
|
158305
|
158306
|
158307
|
161964
|
161965
|
161966
|
161967
|
161968
|
161969
|
162171
|
162172
|
162173
|
162174
|
162175
|
162176
|
162177
|
162178
|
162179
|
162180
|
171620
|
171621
|
171622
|
171623
|
171983
|
171984
|
171985
|
171986
|
172906
|
172907
|
172908
|
172909
|
172910