Attachment 162188 Details for Bug 35904 – Bug 35904: (QA follow-up): tidy up code

[patch] Bug 35904: (QA follow-up): tidy up code

Bug-35904-QA-follow-up-tidy-up-code.patch (text/plain), 1.29 KB, created by Martin Renvoize (ashimema) on 2024-02-15 09:27:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-02-15 09:27:29 UTC

Size: 1.29 KB

patch

obsolete

>From f43a95634fecc215ce9ee0ea9dbce12def255df2 Mon Sep 17 00:00:00 2001
>From: Victor Grousset/tuxayo <victor@tuxayo.net>
>Date: Thu, 15 Feb 2024 04:18:37 +0100
>Subject: [PATCH] Bug 35904: (QA follow-up): tidy up code
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> C4/Auth.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/C4/Auth.pm b/C4/Auth.pm
>index ee0e81c0573..c099dbc28c6 100644
>--- a/C4/Auth.pm
>+++ b/C4/Auth.pm
>@@ -791,7 +791,7 @@ sub checkauth {
>     my $type            = shift;
>     my $emailaddress    = shift;
>     my $template_name   = shift;
>-    my $params          = shift || {}; # do_not_print
>+    my $params          = shift || {};    # do_not_print
>     $type = 'opac' unless $type;
> 
>     if ( $type eq 'opac' && !C4::Context->preference("OpacPublic") ) {
>@@ -1334,7 +1334,7 @@ sub checkauth {
>             $uri->query_param_delete('password');
>             $uri->query_param_delete('koha_login_context');
>             unless ( $params->{do_not_print} ) {
>-                print $query->redirect(-uri => $uri->as_string, -cookie => $cookie, -status=>'303 See other');
>+                print $query->redirect( -uri => $uri->as_string, -cookie => $cookie, -status => '303 See other' );
>                 safe_exit;
>             }
>         }
>-- 
>2.43.1

Actions: View | Diff | Splinter Review

Attachments on bug 35904: 161377 | 161378 | 162134 | 162135 | 162151 | 162168 | 162169 | 162187 | 162188 | 162217