Bugzilla – Attachment 162243 Details for
Bug 36047
Apostrophe in suggestion status reason blocks order receipt
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36047: Workaround the apostrophe
Bug-36047-Workaround-the-apostrophe.patch (text/plain), 1.41 KB, created by
Pedro Amorim
on 2024-02-16 16:59:38 UTC
(
hide
)
Description:
Bug 36047: Workaround the apostrophe
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2024-02-16 16:59:38 UTC
Size:
1.41 KB
patch
obsolete
>From 74324c3dc8be16316647c38dfc97445508754c17 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Fri, 16 Feb 2024 16:58:41 +0000 >Subject: [PATCH] Bug 36047: Workaround the apostrophe > >This is just a quick hack fix highlighting where the issue lies > >the real fix should be escape HTML entities coming from biblio.suggestions >as this fix may also fail in case the data contains double quotes >--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt >index eb834ea4c21..db3b555257e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt >@@ -1150,7 +1150,7 @@ > } > if(row.biblio.suggestions[0].reason) { > $("#suggestion_reason").show(); >- if($("#reason option[value='"+row.biblio.suggestions[0].reason+"']").length) { >+ if($("#reason option[value=\""+row.biblio.suggestions[0].reason+"\"]").length) { > $("#other_reason a").click(); > $("#reason").val(row.biblio.suggestions[0].reason); > $("#select-other_reason").val(null); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36047
:
162243
|
162280
|
162281
|
162285
|
162337
|
162361