Bugzilla – Attachment 162273 Details for
Bug 36130
ILL batches table not showing all batches
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36130: Fetch all batches for the table
Bug-36130-Fetch-all-batches-for-the-table.patch (text/plain), 1.60 KB, created by
David Nind
on 2024-02-19 14:29:36 UTC
(
hide
)
Description:
Bug 36130: Fetch all batches for the table
Filename:
MIME Type:
Creator:
David Nind
Created:
2024-02-19 14:29:36 UTC
Size:
1.60 KB
patch
obsolete
>From 9da338a70429e0141806a79a6735c86b585da241 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Mon, 19 Feb 2024 13:12:25 +0000 >Subject: [PATCH] Bug 36130: Fetch all batches for the table > >Test plan, ktd: >- Add 'FreeForm' backend and enable ILLModule, run: >bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) >- Add 21 batches, run the following command in kshell: >for x in {1..21}; do echo "INSERT INTO illbatches (name, backend, library_id, status_code, patron_id) VALUES ('$x', 'FreeForm', 'CPL', 'NEW', 52);"; done | koha-mysql kohadev >- Visit ILL batches page: ><INTRA_URL>/cgi-bin/koha/ill/ill-requests.pl?method=batch_list >- Notice only 20 batches show. >- Apply patch. Notice 20 batches show but now there is a page 2 link. >- Test page 2 works as expected, delete a batch, notice only 1 page with 20 batches shows again. > >Signed-off-by: David Nind <david@davidnind.com> >--- > koha-tmpl/intranet-tmpl/prog/js/ill-batch-table.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/ill-batch-table.js b/koha-tmpl/intranet-tmpl/prog/js/ill-batch-table.js >index fe535ff16e..b5fd366dc4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/ill-batch-table.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/ill-batch-table.js >@@ -27,7 +27,7 @@ > table = initTable(); > > // Do the initial data population >- window.doBatchApiRequest('', { >+ window.doBatchApiRequest( '?_per_page=-1', { > headers: { > 'x-koha-embed': '+strings,requests+count,patron' > } >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36130
:
162270
|
162273
|
162319
|
162810
|
163025