Attachment 162293 Details for Bug 35582 – Bug 35582: Show advanced search languages with selected intranet language descriptions first

[patch] Bug 35582: Show advanced search languages with selected intranet language descriptions first

Bug-35582-Show-advanced-search-languages-with-sele.patch (text/plain), 1.97 KB, created by Lari Strand on 2024-02-20 11:01:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lari Strand

Created: 2024-02-20 11:01:49 UTC

Size: 1.97 KB

patch

obsolete

>From e1bfedcdd233f3cadfa332d81c5a3543f13d7828 Mon Sep 17 00:00:00 2001
>From: lmstrand <lmstrand@gmail.com>
>Date: Fri, 26 Jan 2024 10:36:00 +0200
>Subject: [PATCH] Bug 35582: Show advanced search languages with selected
> intranet language descriptions first
>
>To test:
>
>1. Check language dropdowns in advanced search, notice localized
>   names of the languages are shown first in the menus, then the
>selected ui language translations if available or the english translation
>2. Apply patch
>3. Check language dropdowns, notice the selected ui language's
>   translations are shown first for the languages (if missing, english
>translation), then the localized
>language's name.
>---
> C4/Languages.pm | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/C4/Languages.pm b/C4/Languages.pm
>index 04f2c8367c..21c4ce4e6f 100644
>--- a/C4/Languages.pm
>+++ b/C4/Languages.pm
>@@ -227,10 +227,11 @@ sub getLanguages {
> 
>             # fill in the ISO6329 code
>             $language_subtag_registry->{iso639_2_code} = $language_descriptions->{iso639_2_code};
>-            # fill in the native description of the language, as well as the current language's translation of that if it exists
>+            # fill in the current selected ui language's translation, as well as the native description of the language
>             if ($native_description) {
>-                $language_subtag_registry->{language_description} = $native_description;
>-                $language_subtag_registry->{language_description}.=" ($language_descriptions->{description})" if $language_descriptions->{description};
>+                $language_subtag_registry->{language_description} = $language_descriptions->{description}
>+                    if $language_descriptions->{description};
>+                $language_subtag_registry->{language_description} .= " ($native_description)";
>             }
>             else {
>                 $language_subtag_registry->{language_description} = $language_descriptions->{description};
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 35582: 159892 | 160621 | 162293 | 162302 | 165692 | 165693