Bugzilla – Attachment 162313 Details for
Bug 35913
Item order prices do not fall back to MarcFieldsToOrder if not set by MarcItemFieldsToOrder
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35913: Restore price fall back to MarcFieldsToOrder if not set by MarcItemFieldsToOrder
Bug-35913-Restore-price-fall-back-to-MarcFieldsToO.patch (text/plain), 1.76 KB, created by
Victor Grousset/tuxayo
on 2024-02-21 05:02:48 UTC
(
hide
)
Description:
Bug 35913: Restore price fall back to MarcFieldsToOrder if not set by MarcItemFieldsToOrder
Filename:
MIME Type:
Creator:
Victor Grousset/tuxayo
Created:
2024-02-21 05:02:48 UTC
Size:
1.76 KB
patch
obsolete
>From f2e65c8f9ae5943d0145aa2e31d74c156d59071c Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Thu, 25 Jan 2024 19:56:31 +0000 >Subject: [PATCH] Bug 35913: Restore price fall back to MarcFieldsToOrder if > not set by MarcItemFieldsToOrder > >To test: >Setup -- Set systempreferences below > >MarcFieldsToOrder: >price: 949$g >quantity: 949$k >budget_code: 949$l >discount: 949$m >sort1: 949$n >sort2: 949$q > >MarcItemFieldsToOrder: >homebranch: 949$a >holdingbranch: 949$b >itype: 949$y >nonpublic_note: 949$x >public_note: 949$z >loc: 949$c >ccode: 949$8 >notforloan: 949$7 >uri: 949$u >copyno: 949$t >price: 949$g >replacementprice: 949$v >itemcallnumber: 949$o >quantity: 949$k >budget_code: 949$l > >Stage the attached bib-303.marcxml file >Add to basket from the staged file >Select the biblio >Note items have prices >Cancel >Remove 'price' mapping from MarcItemFieldsToOrder >Apply patch >Add to basket from file again >Note item prices, and other fields, come through as expected > >Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> >Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> >--- > acqui/addorderiso2709.pl | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/acqui/addorderiso2709.pl b/acqui/addorderiso2709.pl >index e79a0ae447..cf9fb2f732 100755 >--- a/acqui/addorderiso2709.pl >+++ b/acqui/addorderiso2709.pl >@@ -537,6 +537,8 @@ sub import_biblios_list { > $iteminfos->{budget_id} = $item_budget->{budget_id} || $budget_id; > } > >+ $iteminfos->{price} ||= $price; # Fallback to order price if no item price was defined >+ > # Clone the item data for the needed quantity > # Add the incremented item id for each item in that quantity > for (my $i = 0; $i < $quantity; $i++) { >-- >2.43.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35913
:
161464
|
161465
|
161717
| 162313