Bugzilla – Attachment 162360 Details for
Bug 36148
Move CSRF check code outside of CGI->new
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36148: Add explanatory notes
Bug-36148-Add-explanatory-notes.patch (text/plain), 975 bytes, created by
David Cook
on 2024-02-23 05:15:46 UTC
(
hide
)
Description:
Bug 36148: Add explanatory notes
Filename:
MIME Type:
Creator:
David Cook
Created:
2024-02-23 05:15:46 UTC
Size:
975 bytes
patch
obsolete
>From 9dc6653698a88e805fc40c3b1733f1abc42c39a5 Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Fri, 23 Feb 2024 05:15:24 +0000 >Subject: [PATCH] Bug 36148: Add explanatory notes > >--- > Koha/Middleware/CSRF.pm | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/Koha/Middleware/CSRF.pm b/Koha/Middleware/CSRF.pm >index 890f55ae79..c9a30c97ba 100644 >--- a/Koha/Middleware/CSRF.pm >+++ b/Koha/Middleware/CSRF.pm >@@ -69,6 +69,9 @@ sub call { > } > } > >+ #NOTE: It is essential to check for this environmental variable. >+ #NOTE: If we don't check for it, then we'll also throw an error for the "subrequest" that ErrorDocument uses to >+ #fetch the error page document. Then we'll wind up with a very ugly error page and not our pretty one. > if ( $error && !$env->{'plack.middleware.Koha.CSRF'} ) { > > #NOTE: Other Middleware will take care of logging to correct place, as Koha::Logger doesn't know where to go here >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36148
:
162333
|
162336
|
162359
|
162360
|
162362
|
162363
|
162428
|
162505
|
162506
|
162507
|
162508
|
162509
|
162510