Bugzilla – Attachment 162373 Details for
Bug 35921
Improve performance of acquisitions start page when there are many budgets
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35921: (QA follow-up): Less code, less nested code
Bug-35921-QA-follow-up-Less-code-less-nested-code.patch (text/plain), 1.13 KB, created by
Pedro Amorim
on 2024-02-23 10:34:38 UTC
(
hide
)
Description:
Bug 35921: (QA follow-up): Less code, less nested code
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2024-02-23 10:34:38 UTC
Size:
1.13 KB
patch
obsolete
>From 4baede8288e9ed48db40201d3744b6ff6e5121ca Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Fri, 23 Feb 2024 10:33:49 +0000 >Subject: [PATCH] Bug 35921: (QA follow-up): Less code, less nested code > >Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> >--- > acqui/acqui-home.pl | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > >diff --git a/acqui/acqui-home.pl b/acqui/acqui-home.pl >index 87a460b9d5e..f9712638b17 100755 >--- a/acqui/acqui-home.pl >+++ b/acqui/acqui-home.pl >@@ -82,10 +82,8 @@ foreach my $budget ( @{$budget_arr} ) { > next unless (CanUserUseBudget($loggedinpatron, $budget, $userflags)); > > if ( my $borrowernumber = $budget->{budget_owner_id} ) { >- unless (exists $patrons{$borrowernumber}) { >- $patrons{$borrowernumber} = Koha::Patrons->find($borrowernumber); >- } >- $budget->{budget_owner} = $patrons{$borrowernumber}; >+ my $patron_borrowernumber = $patrons{$borrowernumber} // Koha::Patrons->find($borrowernumber); >+ $budget->{budget_owner} = $patron_borrowernumber; > } > > if ( !defined $budget->{budget_amount} ) { >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35921
:
161546
|
162372
|
162373
|
163288
|
163336
|
163337